Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 44466345 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Add @NonNull to some generated methods' args"

parents 82f9350c 1bfb5e70

api/current.txt

+1 −1
Original line number Diff line number Diff line
@@ -4481,7 +4481,7 @@ package android.app { 
    method @IntRange(from=0) public int getNotingUid();

    method @NonNull public String getOp();

    method @IntRange(from=0) public long getTime();

    method public void writeToParcel(android.os.Parcel, int);

    method public void writeToParcel(@NonNull android.os.Parcel, int);

    field @NonNull public static final android.os.Parcelable.Creator<android.app.AsyncNotedAppOp> CREATOR;

  }

























core/java/android/app/AsyncNotedAppOp.java



+51
−25




























Original line number
Diff line number
Diff line








@@ -66,14 +66,18 @@ public final class AsyncNotedAppOp implements Parcelable {



























































    // Code below generated by codegen v1.0.0.













    // Code below generated by codegen v1.0.9.















    //















    // DO NOT MODIFY!













    // CHECKSTYLE:OFF Generated code















    //















    // To regenerate run:















    // $ codegen $ANDROID_BUILD_TOP/frameworks/base/core/java/android/app/AsyncNotedAppOp.java















    //













    // CHECKSTYLE:OFF Generated code













    // To exclude the generated code from IntelliJ auto-formatting enable (one-time):













    //   Settings > Editor > Code Style > Formatter Control













    //@formatter:off













































    /**















     * Creates a new AsyncNotedAppOp.









@@ -83,7 +87,8 @@ public final class AsyncNotedAppOp implements Parcelable {













     * @param notingUid















     *   Uid that noted the op















     * @param notingPackageName













     *   Package that noted the op













     *   Package that noted the op. {@code null} if the package name that noted the op could be not













     *   be determined (e.g. when the op is noted from native code).















     * @param message















     *   Message associated with the noteOp. This message is set by the app noting the op















     * @param time










@@ -127,7 +132,8 @@ public final class AsyncNotedAppOp implements Parcelable {













    }































    /**













     * Package that noted the op













     * Package that noted the op. {@code null} if the package name that noted the op could be not













     * be determined (e.g. when the op is noted from native code).















     */















    @DataClass.Generated.Member















    public @Nullable String getNotingPackageName() {









@@ -152,7 +158,7 @@ public final class AsyncNotedAppOp implements Parcelable {





























    @Override















    @DataClass.Generated.Member













    public boolean equals(Object o) {













    public boolean equals(@Nullable Object o) {















        // You can override field equality logic by defining either of the methods like:















        // boolean fieldNameEquals(AsyncNotedAppOp other) { ... }















        // boolean fieldNameEquals(FieldType otherValue) { ... }










@@ -187,7 +193,7 @@ public final class AsyncNotedAppOp implements Parcelable {





























    @Override















    @DataClass.Generated.Member













    public void writeToParcel(android.os.Parcel dest, int flags) {













    public void writeToParcel(@NonNull android.os.Parcel dest, int flags) {















        // You can override field parcelling by defining methods like:















        // void parcelFieldName(Parcel dest, int flags) { ... }

























@@ -205,17 +211,10 @@ public final class AsyncNotedAppOp implements Parcelable {













    @DataClass.Generated.Member















    public int describeContents() { return 0; }





























    @DataClass.Generated.Member













    public static final @NonNull Parcelable.Creator<AsyncNotedAppOp> CREATOR













            = new Parcelable.Creator<AsyncNotedAppOp>() {













        @Override













        public AsyncNotedAppOp[] newArray(int size) {













            return new AsyncNotedAppOp[size];













        }



























        @Override













    /** @hide */















    @SuppressWarnings({"unchecked", "RedundantCast"})













        public AsyncNotedAppOp createFromParcel(android.os.Parcel in) {













    @DataClass.Generated.Member













    /* package-private */ AsyncNotedAppOp(@NonNull android.os.Parcel in) {















        // You can override field unparcelling by defining methods like:















        // static FieldType unparcelFieldName(Parcel in) { ... }

























@@ -225,18 +224,45 @@ public final class AsyncNotedAppOp implements Parcelable {













        String notingPackageName = (flg & 0x4) == 0 ? null : in.readString();















        String message = in.readString();















        long time = in.readLong();













            return new AsyncNotedAppOp(













                    opCode,













                    notingUid,













                    notingPackageName,













                    message,













                    time);



























        this.mOpCode = opCode;













        com.android.internal.util.AnnotationValidations.validate(













                IntRange.class, null, mOpCode,













                "from", 0,













                "to", AppOpsManager._NUM_OP - 1);













        this.mNotingUid = notingUid;













        com.android.internal.util.AnnotationValidations.validate(













                IntRange.class, null, mNotingUid,













                "from", 0);













        this.mNotingPackageName = notingPackageName;













        this.mMessage = message;













        com.android.internal.util.AnnotationValidations.validate(













                NonNull.class, null, mMessage);













        this.mTime = time;













        com.android.internal.util.AnnotationValidations.validate(













                IntRange.class, null, mTime,













                "from", 0);



























        // onConstructed(); // You can define this method to get a callback













    }



























    @DataClass.Generated.Member













    public static final @NonNull Parcelable.Creator<AsyncNotedAppOp> CREATOR













            = new Parcelable.Creator<AsyncNotedAppOp>() {













        @Override













        public AsyncNotedAppOp[] newArray(int size) {













            return new AsyncNotedAppOp[size];













        }



























        @Override













        public AsyncNotedAppOp createFromParcel(@NonNull android.os.Parcel in) {













            return new AsyncNotedAppOp(in);















        }















    };































    @DataClass.Generated(













            time = 1566503083973L,













            codegenVersion = "1.0.0",













            time = 1571246617363L,













            codegenVersion = "1.0.9",















            sourceFile = "frameworks/base/core/java/android/app/AsyncNotedAppOp.java",















            inputSignatures = "private final @android.annotation.IntRange(from=0L, to=91L) int mOpCode\nprivate final @android.annotation.IntRange(from=0L) int mNotingUid\nprivate final @android.annotation.Nullable java.lang.String mNotingPackageName\nprivate final @android.annotation.NonNull java.lang.String mMessage\nprivate final @android.annotation.IntRange(from=0L) long mTime\npublic @android.annotation.NonNull java.lang.String getOp()\nclass AsyncNotedAppOp extends java.lang.Object implements [android.os.Parcelable]\n@com.android.internal.util.DataClass(genEqualsHashCode=true, genAidl=true, genHiddenConstructor=true)")















    @Deprecated

































tests/Codegen/src/com/android/codegentest/HierrarchicalDataClassBase.java



+6
−6




























Original line number
Diff line number
Diff line








@@ -32,7 +32,7 @@ public class HierrarchicalDataClassBase implements Parcelable {



























































    // Code below generated by codegen v1.0.8.













    // Code below generated by codegen v1.0.9.















    //















    // DO NOT MODIFY!















    // CHECKSTYLE:OFF Generated code









@@ -58,7 +58,7 @@ public class HierrarchicalDataClassBase implements Parcelable {





























    @Override















    @DataClass.Generated.Member













    public void writeToParcel(android.os.Parcel dest, int flags) {













    public void writeToParcel(@android.annotation.NonNull android.os.Parcel dest, int flags) {















        // You can override field parcelling by defining methods like:















        // void parcelFieldName(Parcel dest, int flags) { ... }

























@@ -72,7 +72,7 @@ public class HierrarchicalDataClassBase implements Parcelable {













    /** @hide */















    @SuppressWarnings({"unchecked", "RedundantCast"})















    @DataClass.Generated.Member













    protected HierrarchicalDataClassBase(android.os.Parcel in) {













    protected HierrarchicalDataClassBase(@android.annotation.NonNull android.os.Parcel in) {















        // You can override field unparcelling by defining methods like:















        // static FieldType unparcelFieldName(Parcel in) { ... }

























@@ -92,14 +92,14 @@ public class HierrarchicalDataClassBase implements Parcelable {













        }































        @Override













        public HierrarchicalDataClassBase createFromParcel(android.os.Parcel in) {













        public HierrarchicalDataClassBase createFromParcel(@android.annotation.NonNull android.os.Parcel in) {















            return new HierrarchicalDataClassBase(in);















        }















    };































    @DataClass.Generated(













            time = 1570828332402L,













            codegenVersion = "1.0.8",













            time = 1571258914826L,













            codegenVersion = "1.0.9",















            sourceFile = "frameworks/base/tests/Codegen/src/com/android/codegentest/HierrarchicalDataClassBase.java",















            inputSignatures = "private  int mBaseData\nclass HierrarchicalDataClassBase extends java.lang.Object implements [android.os.Parcelable]\n@com.android.internal.util.DataClass(genConstructor=false, genSetters=true)")















    @Deprecated

































tests/Codegen/src/com/android/codegentest/HierrarchicalDataClassChild.java



+6
−6




























Original line number
Diff line number
Diff line








@@ -46,7 +46,7 @@ public class HierrarchicalDataClassChild extends HierrarchicalDataClassBase {



























































    // Code below generated by codegen v1.0.8.













    // Code below generated by codegen v1.0.9.















    //















    // DO NOT MODIFY!















    // CHECKSTYLE:OFF Generated code










@@ -74,7 +74,7 @@ public class HierrarchicalDataClassChild extends HierrarchicalDataClassBase {





























    @Override















    @DataClass.Generated.Member













    public void writeToParcel(android.os.Parcel dest, int flags) {













    public void writeToParcel(@NonNull android.os.Parcel dest, int flags) {















        // You can override field parcelling by defining methods like:















        // void parcelFieldName(Parcel dest, int flags) { ... }

























@@ -90,7 +90,7 @@ public class HierrarchicalDataClassChild extends HierrarchicalDataClassBase {













    /** @hide */















    @SuppressWarnings({"unchecked", "RedundantCast"})















    @DataClass.Generated.Member













    protected HierrarchicalDataClassChild(android.os.Parcel in) {













    protected HierrarchicalDataClassChild(@NonNull android.os.Parcel in) {















        // You can override field unparcelling by defining methods like:















        // static FieldType unparcelFieldName(Parcel in) { ... }

























@@ -114,14 +114,14 @@ public class HierrarchicalDataClassChild extends HierrarchicalDataClassBase {













        }































        @Override













        public HierrarchicalDataClassChild createFromParcel(android.os.Parcel in) {













        public HierrarchicalDataClassChild createFromParcel(@NonNull android.os.Parcel in) {















            return new HierrarchicalDataClassChild(in);















        }















    };































    @DataClass.Generated(













            time = 1570828333399L,













            codegenVersion = "1.0.8",













            time = 1571258915848L,













            codegenVersion = "1.0.9",















            sourceFile = "frameworks/base/tests/Codegen/src/com/android/codegentest/HierrarchicalDataClassChild.java",















            inputSignatures = "private @android.annotation.NonNull java.lang.String mChildData\nclass HierrarchicalDataClassChild extends com.android.codegentest.HierrarchicalDataClassBase implements []\n@com.android.internal.util.DataClass(genParcelable=true, genConstructor=false, genSetters=true)")















    @Deprecated

































tests/Codegen/src/com/android/codegentest/ParcelAllTheThingsDataClass.java



+6
−6




























Original line number
Diff line number
Diff line








@@ -52,7 +52,7 @@ public class ParcelAllTheThingsDataClass implements Parcelable {



























































    // Code below generated by codegen v1.0.8.













    // Code below generated by codegen v1.0.9.















    //















    // DO NOT MODIFY!















    // CHECKSTYLE:OFF Generated code










@@ -161,7 +161,7 @@ public class ParcelAllTheThingsDataClass implements Parcelable {





























    @Override















    @DataClass.Generated.Member













    public void writeToParcel(Parcel dest, int flags) {













    public void writeToParcel(@NonNull Parcel dest, int flags) {















        // You can override field parcelling by defining methods like:















        // void parcelFieldName(Parcel dest, int flags) { ... }

























@@ -185,7 +185,7 @@ public class ParcelAllTheThingsDataClass implements Parcelable {













    /** @hide */















    @SuppressWarnings({"unchecked", "RedundantCast"})















    @DataClass.Generated.Member













    protected ParcelAllTheThingsDataClass(Parcel in) {













    protected ParcelAllTheThingsDataClass(@NonNull Parcel in) {















        // You can override field unparcelling by defining methods like:















        // static FieldType unparcelFieldName(Parcel in) { ... }


























@@ -237,7 +237,7 @@ public class ParcelAllTheThingsDataClass implements Parcelable {













        }































        @Override













        public ParcelAllTheThingsDataClass createFromParcel(Parcel in) {













        public ParcelAllTheThingsDataClass createFromParcel(@NonNull Parcel in) {















            return new ParcelAllTheThingsDataClass(in);















        }















    };










@@ -410,8 +410,8 @@ public class ParcelAllTheThingsDataClass implements Parcelable {













    }































    @DataClass.Generated(













            time = 1570828331396L,













            codegenVersion = "1.0.8",













            time = 1571258913802L,













            codegenVersion = "1.0.9",















            sourceFile = "frameworks/base/tests/Codegen/src/com/android/codegentest/ParcelAllTheThingsDataClass.java",















            inputSignatures = " @android.annotation.NonNull java.lang.String[] mStringArray\n @android.annotation.NonNull int[] mIntArray\n @android.annotation.NonNull java.util.List<java.lang.String> mStringList\n @android.annotation.NonNull java.util.Map<java.lang.String,com.android.codegentest.SampleWithCustomBuilder> mMap\n @android.annotation.NonNull java.util.Map<java.lang.String,java.lang.String> mStringMap\n @android.annotation.NonNull android.util.SparseArray<com.android.codegentest.SampleWithCustomBuilder> mSparseArray\n @android.annotation.NonNull android.util.SparseIntArray mSparseIntArray\n @java.lang.SuppressWarnings({\"WeakerAccess\"}) @android.annotation.Nullable java.lang.Boolean mNullableBoolean\nclass ParcelAllTheThingsDataClass extends java.lang.Object implements [android.os.Parcelable]\n@com.android.internal.util.DataClass(genBuilder=true, genAidl=false, genToString=true)")















    @Deprecated