Commit 43e7e0ad authored Jan 07, 2021 by Todd Kennedy

Ensure OK/Cancel buttons always shown

There is some weirdness with the way the AlertActivity behaves when
it's populated and elements are enabled while it's not actually on
the screen. Work around this by populating the AlertActivity during
onResume() [eg. every time the activity is shown] instead of
onCreate() [eg. only the first time the activity is created].

Test: Manual
Test: Start a staging install
Test: Turn off the phone screen
Test: Wait for the staging to complete
Test: Turn on the phone screen.
Test: See the install dialog has OK/Cancel buttons
Change-Id: Ia9525f20f98f42e6b2b865fa926b9707d416cde4

parent 70c3cc17

packages/PackageInstaller/src/com/android/packageinstaller/PackageInstallerActivity.java

+7 −5

Original line number	Diff line number	Diff line
		@@ -347,17 +347,19 @@ public class PackageInstallerActivity extends AlertActivity {
		if (!wasSetUp) {
		return;
		}
		}

		@Override
		protected void onResume() {
		super.onResume();

		if (mAppSnippet != null) {
		// load dummy layout with OK button disabled until we override this layout in
		// startInstallConfirm
		bindUi();
		checkIfAllowedAndInitiateInstall();
		}

		@Override
		protected void onResume() {
		super.onResume();

		if (mOk != null) {
		mOk.setEnabled(mEnableOk);
		}