Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 43c49e77 authored by Jeff DeCew's avatar Jeff DeCew
Browse files

New Pipeline: Ensure finalize filter stage is not used unnecessarily. 

Test: manually test media
Change-Id: I83b6f4ba6711d371a0ceb485316a61e284e79374
parent 0e981bc3

packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/BubbleCoordinator.java

+2 −5
Original line number Original line Diff line number Diff line
@@ -82,11 +82,8 @@ public class BubbleCoordinator implements Coordinator { 
    public void attach(NotifPipeline pipeline) {

    public void attach(NotifPipeline pipeline) {

        mNotifPipeline = pipeline;

        mNotifPipeline = pipeline;

        mNotifPipeline.addNotificationDismissInterceptor(mDismissInterceptor);

        mNotifPipeline.addNotificationDismissInterceptor(mDismissInterceptor);

        mNotifPipeline.addFinalizeFilter(mNotifFilter);

        mNotifPipeline.addPreGroupFilter(mNotifFilter);

        if (mBubblesManagerOptional.isPresent()) {

        mBubblesManagerOptional.ifPresent(manager -> manager.addNotifCallback(mNotifCallback));

            mBubblesManagerOptional.get().addNotifCallback(mNotifCallback);

        }



    }

    }





    private final NotifFilter mNotifFilter = new NotifFilter(TAG) {

    private final NotifFilter mNotifFilter = new NotifFilter(TAG) {

packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/KeyguardCoordinator.java

+1 −0
Original line number Original line Diff line number Diff line
@@ -90,6 +90,7 @@ public class KeyguardCoordinator implements Coordinator { 
        readShowSilentNotificationSetting();

        readShowSilentNotificationSetting();





        setupInvalidateNotifListCallbacks();

        setupInvalidateNotifListCallbacks();

        // Filter at the "finalize" stage so that views remain bound by PreparationCoordinator

        pipeline.addFinalizeFilter(mNotifFilter);

        pipeline.addFinalizeFilter(mNotifFilter);

    }

    }

packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/MediaCoordinator.java

+1 −1
Original line number Original line Diff line number Diff line
@@ -49,6 +49,6 @@ public class MediaCoordinator implements Coordinator { 




    @Override

    @Override

    public void attach(NotifPipeline pipeline) {

    public void attach(NotifPipeline pipeline) {

        pipeline.addFinalizeFilter(mMediaFilter);

        pipeline.addPreGroupFilter(mMediaFilter);

    }

    }

}
 
}