Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 438018d1 authored by Remi NGUYEN VAN's avatar Remi NGUYEN VAN
Browse files

Remove usage of Context.NETWORK_STACK_SERVICE 

The NetworkStack.getService() API should be used instead.

Bug: 151243982
Test: atest FrameworksNetTests TetheringTests
      Manual tethering test
Change-Id: I7855090bffbe895c8349ad4903b8f2eb55515f0b
parent 53f0193f

packages/Tethering/src/com/android/server/connectivity/tethering/TetheringService.java

+2 −2
Original line number Diff line number Diff line
@@ -33,6 +33,7 @@ import android.net.ITetheringConnector; 
import android.net.ITetheringEventCallback;

import android.net.NetworkCapabilities;

import android.net.NetworkRequest;

import android.net.NetworkStack;

import android.net.TetheringRequestParcel;

import android.net.dhcp.DhcpServerCallbacks;

import android.net.dhcp.DhcpServingParamsParcel;
@@ -364,8 +365,7 @@ public class TetheringService extends Service { 
                    IBinder connector;

                    try {

                        final long before = System.currentTimeMillis();

                        while ((connector = (IBinder) mContext.getSystemService(

                                Context.NETWORK_STACK_SERVICE)) == null) {

                        while ((connector = NetworkStack.getService()) == null) {

                            if (System.currentTimeMillis() - before > NETWORKSTACK_TIMEOUT_MS) {

                                Log.wtf(TAG, "Timeout, fail to get INetworkStackConnector");

                                return null;

tests/net/java/com/android/server/ConnectivityServiceTest.java

+0 −1
Original line number Diff line number Diff line
@@ -428,7 +428,6 @@ public class ConnectivityServiceTest { 
        public Object getSystemService(String name) {

            if (Context.CONNECTIVITY_SERVICE.equals(name)) return mCm;

            if (Context.NOTIFICATION_SERVICE.equals(name)) return mNotificationManager;

            if (Context.NETWORK_STACK_SERVICE.equals(name)) return mNetworkStack;

            if (Context.USER_SERVICE.equals(name)) return mUserManager;

            if (Context.ALARM_SERVICE.equals(name)) return mAlarmManager;

            if (Context.LOCATION_SERVICE.equals(name)) return mLocationManager;