Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 43675340 authored by Leon Scroggins III's avatar Leon Scroggins III
Browse files

slice() the ByteBuffer passed to ImageDecoder 

Bug: 73788928
Test: I7d5082ba7319c6c069dde5d0efb22af6e92dd243

This way the input's position is unaffected. Update the docs to reflect
the new behavior.

Change-Id: I7212948ee289ea8da1be9fe81d3f4bc9296e3e61
parent 5f7e948a

graphics/java/android/graphics/ImageDecoder.java

+8 −6
Original line number Diff line number Diff line
@@ -568,16 +568,18 @@ public final class ImageDecoder implements AutoCloseable { 
    /**

     * Create a new {@link Source} from a {@link java.nio.ByteBuffer}.

     *

     * <p>The returned {@link Source} effectively takes ownership of the

     * {@link java.nio.ByteBuffer}; i.e. no other code should modify it after

     * this call.</p>

     * <p>Decoding will start from {@link java.nio.ByteBuffer#position()}. The

     * position of {@code buffer} will not be affected.</p>

     *

     * Decoding will start from {@link java.nio.ByteBuffer#position()}. The

     * position after decoding is undefined.

     * <p>Note: If this {@code Source} is passed to {@link #decodeDrawable}, and

     * the encoded image is animated, the returned {@link AnimatedImageDrawable}

     * will continue reading from the {@code buffer}, so its contents must not

     * be modified, even after the {@code AnimatedImageDrawable} is returned.

     * {@code buffer}'s contents should never be modified during decode.</p>

     */

    @NonNull

    public static Source createSource(@NonNull ByteBuffer buffer) {

        return new ByteBufferSource(buffer);

        return new ByteBufferSource(buffer.slice());

    }



    /**