Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 423f753e authored by Bookatz's avatar Bookatz
Browse files

statsd AnomalyDetection improvements 

Re-add check to make sure that bad config won't cause duration
anomaly detection to crash stastd

Bug: 74399947
Test: manual
Change-Id: Id175d233685c133ec3d4231272fe5708250dee6b
parent 983c1e54

cmds/statsd/src/metrics/DurationMetricProducer.cpp

+7 −0
Original line number Diff line number Diff line
@@ -124,6 +124,13 @@ DurationMetricProducer::~DurationMetricProducer() { 
sp<AnomalyTracker> DurationMetricProducer::addAnomalyTracker(

        const Alert &alert, const sp<AlarmMonitor>& anomalyAlarmMonitor) {

    std::lock_guard<std::mutex> lock(mMutex);

    if (mAggregationType == DurationMetric_AggregationType_SUM) {

        if (alert.trigger_if_sum_gt() > alert.num_buckets() * mBucketSizeNs) {

            ALOGW("invalid alert for SUM: threshold (%f) > possible recordable value (%d x %lld)",

                  alert.trigger_if_sum_gt(), alert.num_buckets(), (long long)mBucketSizeNs);

            return nullptr;

        }

    }

    sp<DurationAnomalyTracker> anomalyTracker =

        new DurationAnomalyTracker(alert, mConfigKey, anomalyAlarmMonitor);

    if (anomalyTracker != nullptr) {