Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 41c64863 authored by Torne (Richard Coles)'s avatar Torne (Richard Coles)
Browse files

WebView: note deprecation of onscreen zoom controls. 

Inform developers that having onscreen zoom controls is deprecated and
that it's therefore not recommended to enable them in WebView, with
reference to ZoomButtonsController (which is what WebView uses to
implement them).

Bug: 141732094
Test: make ds-docs
Change-Id: I134551b87d3a93072e28aef56667507214b3e9c4
parent 9c6d7fe4

core/java/android/webkit/WebSettings.java

+6 −1
Original line number Diff line number Diff line
@@ -328,6 +328,9 @@ public abstract class WebSettings { 
     * <p>

     * The built-in mechanisms are the only currently supported zoom

     * mechanisms, so it is recommended that this setting is always enabled.

     * However, on-screen zoom controls are deprecated in Android (see

     * {@link android.widget.ZoomButtonsController}) so it's recommended to

     * disable {@link #setDisplayZoomControls}.

     *

     * @param enabled whether the WebView should use its built-in zoom mechanisms

     */
@@ -347,7 +350,9 @@ public abstract class WebSettings { 
    /**

     * Sets whether the WebView should display on-screen zoom controls when

     * using the built-in zoom mechanisms. See {@link #setBuiltInZoomControls}.

     * The default is {@code true}.

     * The default is {@code true}. However, on-screen zoom controls are deprecated

     * in Android (see {@link android.widget.ZoomButtonsController}) so it's

     * recommended to set this to {@code false}.

     *

     * @param enabled whether the WebView should display on-screen zoom controls

     */