Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4125e10f authored by Jeff DeCew's avatar Jeff DeCew
Browse files

[flexiglass] HACKY: fix animations in NSSL 

Removing NPVC removed the enable/disable of animations inside NSSL.  We can probably solve this with the NSV binder, but for now they are just always enabled (when flexiglass is).

Bug: 332732878
Test: expanding or dismissing notifications now animates the stack
Flag: ACONFIG com.android.systemui.scene_container DEVELOPMENT
Change-Id: I6372d76b98dffa635949e0ab3a0f56fec9e5afce
parent d83844f8

packages/SystemUI/src/com/android/systemui/shade/NotificationPanelViewController.java

+1 −0
Original line number Diff line number Diff line
@@ -3174,6 +3174,7 @@ public final class NotificationPanelViewController implements ShadeSurface, Dump 
            }

            notifyExpandingFinished();

        }

        // TODO(b/332732878): replace this call when scene container is enabled

        mNotificationStackScrollLayoutController.setAnimationsEnabled(!disabled);

    }

packages/SystemUI/src/com/android/systemui/shade/ShadeSurfaceImpl.kt

+1 −1
Original line number Diff line number Diff line
@@ -46,7 +46,7 @@ class ShadeSurfaceImpl @Inject constructor() : ShadeSurface, ShadeViewController 
    }



    override fun setTouchAndAnimationDisabled(disabled: Boolean) {

        // TODO(b/322197941): determine if still needed

        // TODO(b/332732878): determine if still needed

    }



    override fun setWillPlayDelayedDozeAmountAnimation(willPlay: Boolean) {

packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/NotificationStackScrollLayout.java

+3 −1
Original line number Diff line number Diff line
@@ -230,7 +230,8 @@ public class NotificationStackScrollLayout extends ViewGroup implements Dumpable 
    private final ArrayList<View> mSwipedOutViews = new ArrayList<>();

    private NotificationStackSizeCalculator mNotificationStackSizeCalculator;

    private final StackStateAnimator mStateAnimator;

    private boolean mAnimationsEnabled;

    // TODO(b/332732878): call setAnimationsEnabled with scene container enabled, then remove this

    private boolean mAnimationsEnabled = SceneContainerFlag.isEnabled();

    private boolean mChangePositionInProgress;

    private boolean mChildTransferInProgress;
@@ -2904,6 +2905,7 @@ public class NotificationStackScrollLayout extends ViewGroup implements Dumpable 
    }



    public void setAnimationsEnabled(boolean animationsEnabled) {

        // TODO(b/332732878): remove the initial value of this field once the setter is called

        mAnimationsEnabled = animationsEnabled;

        updateNotificationAnimationStates();

        if (!animationsEnabled) {