Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ffc8090 authored by Tyler Gunn's avatar Tyler Gunn
Browse files

Add catch block for ClassCastException in areBundlesEqual. 

We've now ween a couple cases where a ClassCastException is happening in
the areBundlesEqual method.  It is not clear what is causing that issue
so instead of just silently catching this exception, we'll log which key
is causing the problem so we can investigate further.

Test: Compile; run tests -- this is not easily repro.
Flag: NONE crash logs only.
Fixes: 390386486
Bug: 372319846
Change-Id: I96c5d08617487add9ba83de80144ae8b2f74782d
parent c271045a

telecomm/java/android/telecom/Call.java

+7 −0
Original line number Diff line number Diff line
@@ -52,6 +52,8 @@ import java.util.concurrent.CopyOnWriteArrayList; 
 * Represents an ongoing phone call that the in-call app should present to the user.

 */

public final class Call {

    private static final String LOG_TAG = "TelecomCall";



    /**

     * The state of a {@code Call} when newly created.

     */
@@ -2912,6 +2914,11 @@ public final class Call { 
                    }

                } catch (BadParcelableException e) {

                    return false;

                } catch (ClassCastException e) {

                    Log.e(LOG_TAG, e, "areBundlesEqual: failure comparing bundle key %s", key);

                    // until we know what is causing this, we should rethrow -- this is still not

                    // expected.

                    throw e;

                }

            }

        }