Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ff560d7 authored by jsh's avatar jsh
Browse files

Send "encoding problem" to the network for general errors during SMS dispatch. 

Previously we were returning "other terminal problem" to the network, but this
had the potential of blocking MT SMS messages for days at a time (eg, if the
problematic message is resent).  Sending the "encoding problem" cause code is
reasonable since in most cases the we have encountered an error while trying
to parse the message.

Addresses b/2200412.
parent f702f1f3

telephony/java/com/android/internal/telephony/CommandsInterface.java

+1 −0
Original line number Diff line number Diff line
@@ -148,6 +148,7 @@ public interface CommandsInterface { 
    static final int CDMA_SMS_FAIL_CAUSE_INVALID_TELESERVICE_ID     = 4;

    static final int CDMA_SMS_FAIL_CAUSE_RESOURCE_SHORTAGE          = 35;

    static final int CDMA_SMS_FAIL_CAUSE_OTHER_TERMINAL_PROBLEM     = 39;

    static final int CDMA_SMS_FAIL_CAUSE_ENCODING_PROBLEM           = 96;



    //***** Methods

telephony/java/com/android/internal/telephony/cdma/CdmaSMSDispatcher.java

+1 −1
Original line number Diff line number Diff line
@@ -481,7 +481,7 @@ final class CdmaSMSDispatcher extends SMSDispatcher { 
            return CommandsInterface.CDMA_SMS_FAIL_CAUSE_INVALID_TELESERVICE_ID;

        case Intents.RESULT_SMS_GENERIC_ERROR:

        default:

            return CommandsInterface.CDMA_SMS_FAIL_CAUSE_OTHER_TERMINAL_PROBLEM;

            return CommandsInterface.CDMA_SMS_FAIL_CAUSE_ENCODING_PROBLEM;

        }

    }

}