Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ff037cb authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Un-obscure the Telephony phone account ID." into tm-dev

parents 778f431a 8a979331
Loading
Loading
Loading
Loading
+25 −8
Original line number Diff line number Diff line
@@ -46,6 +46,14 @@ import java.util.Objects;
 * See {@link PhoneAccount}, {@link TelecomManager}.
 */
public final class PhoneAccountHandle implements Parcelable {
    /**
     * Expected component name of Telephony phone accounts; ONLY used to determine if we should log
     * the phone account handle ID.
     */
    private static final ComponentName TELEPHONY_COMPONENT_NAME =
            new ComponentName("com.android.phone",
                    "com.android.services.telephony.TelephonyConnectionService");

    @UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P, trackingBug = 127403196)
    private final ComponentName mComponentName;
    @UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P, trackingBug = 115609023)
@@ -136,14 +144,23 @@ public final class PhoneAccountHandle implements Parcelable {

    @Override
    public String toString() {
        StringBuilder sb = new StringBuilder()
                .append(mComponentName)
                .append(", ");

        if (TELEPHONY_COMPONENT_NAME.equals(mComponentName)) {
            // Telephony phone account handles are now keyed by subscription id which is not
            // sensitive.
            sb.append(mId);
        } else {
            // Note: Log.pii called for mId as it can contain personally identifying phone account
            // information such as SIP account IDs.
        return new StringBuilder().append(mComponentName)
                    .append(", ")
                    .append(Log.pii(mId))
                    .append(", ")
                    .append(mUserHandle)
                    .toString();
            sb.append(Log.pii(mId));
        }
        sb.append(", ");
        sb.append(mUserHandle);

        return sb.toString();
    }

    @Override