Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3fd8781f authored by Massimo Carli's avatar Massimo Carli
Browse files

[40/n] Simplify methods naming for Reachability 

Flag: EXEMPT Renaming and small refactoring
Bug: 384473893
Test: atest WmTests:AppCompatReachabilityOverridesTest
Test: atest WmTests:AppCompatReachabilityPolicyTest
Test: atest WmTests:SizeCompatTests

Change-Id: I4a59a0f5b2329d2cfe92a7c9ed760de0110b2e2c
parent 3e57b158

services/core/java/com/android/server/wm/ActivityMetricsLogger.java

+1 −1
Original line number Diff line number Diff line
@@ -1631,7 +1631,7 @@ class ActivityMetricsLogger { 


        int positionToLog = APP_COMPAT_STATE_CHANGED__LETTERBOX_POSITION__NOT_LETTERBOXED_POSITION;

        if (isAppCompateStateChangedToLetterboxed(state)) {

            positionToLog = activity.mAppCompatController.getAppCompatReachabilityOverrides()

            positionToLog = activity.mAppCompatController.getReachabilityOverrides()

                    .getLetterboxPositionForLogging();

        }

        FrameworkStatsLog.write(FrameworkStatsLog.APP_COMPAT_STATE_CHANGED,

services/core/java/com/android/server/wm/ActivityRecord.java

+1 −1
Original line number Diff line number Diff line
@@ -8744,7 +8744,7 @@ final class ActivityRecord extends WindowToken implements WindowManagerService.A 
            navBarInsets = Insets.NONE;

        }

        final AppCompatReachabilityOverrides reachabilityOverrides =

                mAppCompatController.getAppCompatReachabilityOverrides();

                mAppCompatController.getReachabilityOverrides();

        // Horizontal position

        int offsetX = 0;

        if (parentBounds.width() != screenResolvedBoundsWidth) {

services/core/java/com/android/server/wm/AppCompatController.java

+6 −6
Original line number Diff line number Diff line
@@ -33,7 +33,7 @@ class AppCompatController { 
    @NonNull

    private final AppCompatAspectRatioPolicy mAppCompatAspectRatioPolicy;

    @NonNull

    private final AppCompatReachabilityPolicy mAppCompatReachabilityPolicy;

    private final AppCompatReachabilityPolicy mReachabilityPolicy;

    @NonNull

    private final DesktopAppCompatAspectRatioPolicy mDesktopAppCompatAspectRatioPolicy;

    @NonNull
@@ -58,7 +58,7 @@ class AppCompatController { 
        mOrientationPolicy = new AppCompatOrientationPolicy(activityRecord, mAppCompatOverrides);

        mAppCompatAspectRatioPolicy = new AppCompatAspectRatioPolicy(activityRecord,

                mTransparentPolicy, mAppCompatOverrides);

        mAppCompatReachabilityPolicy = new AppCompatReachabilityPolicy(activityRecord,

        mReachabilityPolicy = new AppCompatReachabilityPolicy(activityRecord,

                wmService.mAppCompatConfiguration);

        mAppCompatLetterboxPolicy = new AppCompatLetterboxPolicy(activityRecord,

                wmService.mAppCompatConfiguration);
@@ -109,8 +109,8 @@ class AppCompatController { 
    }



    @NonNull

    AppCompatReachabilityPolicy getAppCompatReachabilityPolicy() {

        return mAppCompatReachabilityPolicy;

    AppCompatReachabilityPolicy getReachabilityPolicy() {

        return mReachabilityPolicy;

    }



    @NonNull
@@ -124,8 +124,8 @@ class AppCompatController { 
    }



    @NonNull

    AppCompatReachabilityOverrides getAppCompatReachabilityOverrides() {

        return mAppCompatOverrides.getAppCompatReachabilityOverrides();

    AppCompatReachabilityOverrides getReachabilityOverrides() {

        return mAppCompatOverrides.getReachabilityOverrides();

    }



    @NonNull

services/core/java/com/android/server/wm/AppCompatLetterboxPolicy.java

+7 −7
Original line number Diff line number Diff line
@@ -205,7 +205,7 @@ class AppCompatLetterboxPolicy { 
        }

        pw.println(prefix + "  letterboxReason="

                + AppCompatUtils.getLetterboxReasonString(mActivityRecord, mainWin));

        mActivityRecord.mAppCompatController.getAppCompatReachabilityPolicy().dump(pw, prefix);

        mActivityRecord.mAppCompatController.getReachabilityPolicy().dump(pw, prefix);

        final AppCompatLetterboxOverrides letterboxOverride = mActivityRecord.mAppCompatController

                .getAppCompatLetterboxOverrides();

        pw.println(prefix + "  letterboxBackgroundColor=" + Integer.toHexString(
@@ -276,12 +276,12 @@ class AppCompatLetterboxPolicy { 
                final AppCompatLetterboxOverrides letterboxOverrides = mActivityRecord

                        .mAppCompatController.getAppCompatLetterboxOverrides();

                final AppCompatReachabilityPolicy reachabilityPolicy = mActivityRecord

                        .mAppCompatController.getAppCompatReachabilityPolicy();

                        .mAppCompatController.getReachabilityPolicy();

                mLetterbox = new Letterbox(() -> mActivityRecord.makeChildSurface(null),

                        mActivityRecord.mWmService.mTransactionFactory,

                        reachabilityPolicy, letterboxOverrides,

                        this::getLetterboxParentSurface);

                mActivityRecord.mAppCompatController.getAppCompatReachabilityPolicy()

                mActivityRecord.mAppCompatController.getReachabilityPolicy()

                        .setLetterboxInnerBoundsSupplier(mLetterbox::getInnerFrame);

            }

            final Point letterboxPosition = new Point();
@@ -291,7 +291,7 @@ class AppCompatLetterboxPolicy { 
            final Rect innerFrame = new Rect();

            calculateLetterboxInnerBounds(mActivityRecord, w, innerFrame);

            mLetterbox.layout(spaceToFill, innerFrame, letterboxPosition);

            if (mActivityRecord.mAppCompatController.getAppCompatReachabilityOverrides()

            if (mActivityRecord.mAppCompatController.getReachabilityOverrides()

                    .isDoubleTapEvent()) {

                // We need to notify Shell that letterbox position has changed.

                mActivityRecord.getTask().dispatchTaskInfoChangedIfNeeded(true /* force */);
@@ -321,7 +321,7 @@ class AppCompatLetterboxPolicy { 
                mLetterbox.destroy();

                mLetterbox = null;

            }

            mActivityRecord.mAppCompatController.getAppCompatReachabilityPolicy()

            mActivityRecord.mAppCompatController.getReachabilityPolicy()

                    .setLetterboxInnerBoundsSupplier(null);

        }
@@ -415,7 +415,7 @@ class AppCompatLetterboxPolicy { 
            calculateLetterboxPosition(mActivityRecord, mLetterboxPosition);

            calculateLetterboxOuterBounds(mActivityRecord, mOuterBounds);

            calculateLetterboxInnerBounds(mActivityRecord, w, mInnerBounds);

            mActivityRecord.mAppCompatController.getAppCompatReachabilityPolicy()

            mActivityRecord.mAppCompatController.getReachabilityPolicy()

                    .setLetterboxInnerBoundsSupplier(() -> mInnerBounds);

        }
@@ -438,7 +438,7 @@ class AppCompatLetterboxPolicy { 
            mLetterboxPosition.set(0, 0);

            mInnerBounds.setEmpty();

            mOuterBounds.setEmpty();

            mActivityRecord.mAppCompatController.getAppCompatReachabilityPolicy()

            mActivityRecord.mAppCompatController.getReachabilityPolicy()

                    .setLetterboxInnerBoundsSupplier(null);

        }

services/core/java/com/android/server/wm/AppCompatOverrides.java

+5 −5
Original line number Diff line number Diff line
@@ -37,7 +37,7 @@ public class AppCompatOverrides { 
    @NonNull

    private final AppCompatResizeOverrides mResizeOverrides;

    @NonNull

    private final AppCompatReachabilityOverrides mAppCompatReachabilityOverrides;

    private final AppCompatReachabilityOverrides mReachabilityOverrides;

    @NonNull

    private final AppCompatLetterboxOverrides mAppCompatLetterboxOverrides;
@@ -50,11 +50,11 @@ public class AppCompatOverrides { 
                appCompatConfiguration, optPropBuilder);

        mAppCompatOrientationOverrides = new AppCompatOrientationOverrides(activityRecord,

                appCompatConfiguration, optPropBuilder, mAppCompatCameraOverrides);

        mAppCompatReachabilityOverrides = new AppCompatReachabilityOverrides(activityRecord,

        mReachabilityOverrides = new AppCompatReachabilityOverrides(activityRecord,

                appCompatConfiguration, appCompatDeviceStateQuery);

        mAppCompatAspectRatioOverrides = new AppCompatAspectRatioOverrides(activityRecord,

                appCompatConfiguration, optPropBuilder, appCompatDeviceStateQuery,

                mAppCompatReachabilityOverrides);

                mReachabilityOverrides);

        mAppCompatFocusOverrides = new AppCompatFocusOverrides(activityRecord,

                appCompatConfiguration, optPropBuilder);

        mResizeOverrides = new AppCompatResizeOverrides(activityRecord, packageManager,
@@ -89,8 +89,8 @@ public class AppCompatOverrides { 
    }



    @NonNull

    AppCompatReachabilityOverrides getAppCompatReachabilityOverrides() {

        return mAppCompatReachabilityOverrides;

    AppCompatReachabilityOverrides getReachabilityOverrides() {

        return mReachabilityOverrides;

    }



    @NonNull