Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f98817e authored by Kweku Adams's avatar Kweku Adams
Browse files

Implement remaining ServiceConnection APIs. 

Make sure JobServiceContext reacts appropriately when the binding dies
or the JobService returns a null binding.

Bug: 195034388
Test: N/A
Change-Id: Id1eb88bf6cfbf41b272b43593d97fe4dfbb59d58
parent 1548f793

apex/jobscheduler/service/java/com/android/server/job/JobServiceContext.java

+36 −0
Original line number Diff line number Diff line
@@ -531,6 +531,42 @@ public final class JobServiceContext implements ServiceConnection { 
        }

    }



    @Override

    public void onBindingDied(ComponentName name) {

        synchronized (mLock) {

            if (mRunningJob == null) {

                Slog.e(TAG, "Binding died for " + name.getPackageName()

                        + " but no running job on this context");

            } else if (mRunningJob.getServiceComponent().equals(name)) {

                Slog.e(TAG, "Binding died for "

                        + mRunningJob.getSourceUserId() + ":" + name.getPackageName());

            } else {

                Slog.e(TAG, "Binding died for " + name.getPackageName()

                        + " but context is running a different job");

            }

            closeAndCleanupJobLocked(true /* needsReschedule */, "binding died");

        }

    }



    @Override

    public void onNullBinding(ComponentName name) {

        synchronized (mLock) {

            if (mRunningJob == null) {

                Slog.wtf(TAG, "Got null binding for " + name.getPackageName()

                        + " but no running job on this context");

            } else if (mRunningJob.getServiceComponent().equals(name)) {

                Slog.wtf(TAG, "Got null binding for "

                        + mRunningJob.getSourceUserId() + ":" + name.getPackageName());

            } else {

                Slog.wtf(TAG, "Got null binding for " + name.getPackageName()

                        + " but context is running a different job");

            }

            // Don't reschedule the job since returning a null binding is an explicit choice by the

            // app which breaks things.

            closeAndCleanupJobLocked(false /* needsReschedule */, "null binding");

        }

    }



    /**

     * This class is reused across different clients, and passes itself in as a callback. Check

     * whether the client exercising the callback is the client we expect.