Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f3354e0 authored Apr 21, 2017 by Abodunrinwa Toki

Undeprecate WebView.findAddress

Reverts I772961bd20bff4817a060f14a843abeceb55ac92
Until we bring back TextClassifier.getLinks
See I275a9d055ef0ab68f3ca339c37ee939257c4bd54

Test: none
Bug: 22362008
Bug: 37565246
Change-Id: I2948f22cf4c3462491f47376af48624697703969

parent e70ce27c

api/current.txt

+2 −2

Original line number	Diff line number	Diff line
		@@ -42735,7 +42735,7 @@ package android.text.util {
		method public static final boolean addLinks(android.text.Spannable, java.util.regex.Pattern, java.lang.String, java.lang.String[], android.text.util.Linkify.MatchFilter, android.text.util.Linkify.TransformFilter);
		field public static final int ALL = 15; // 0xf
		field public static final int EMAIL_ADDRESSES = 2; // 0x2
		field public static final deprecated int MAP_ADDRESSES = 8; // 0x8
		field public static final int MAP_ADDRESSES = 8; // 0x8
		field public static final int PHONE_NUMBERS = 4; // 0x4
		field public static final int WEB_URLS = 1; // 0x1
		field public static final android.text.util.Linkify.MatchFilter sPhoneNumberMatchFilter;
		@@ -48975,7 +48975,7 @@ package android.webkit {
		method public void documentHasImages(android.os.Message);
		method public static void enableSlowWholeDocumentDraw();
		method public void evaluateJavascript(java.lang.String, android.webkit.ValueCallback<java.lang.String>);
		method public static deprecated java.lang.String findAddress(java.lang.String);
		method public static java.lang.String findAddress(java.lang.String);
		method public deprecated int findAll(java.lang.String);
		method public void findAllAsync(java.lang.String);
		method public void findNext(boolean);

api/system-current.txt

+2 −2

Original line number	Diff line number	Diff line
		@@ -46312,7 +46312,7 @@ package android.text.util {
		method public static final boolean addLinks(android.text.Spannable, java.util.regex.Pattern, java.lang.String, java.lang.String[], android.text.util.Linkify.MatchFilter, android.text.util.Linkify.TransformFilter);
		field public static final int ALL = 15; // 0xf
		field public static final int EMAIL_ADDRESSES = 2; // 0x2
		field public static final deprecated int MAP_ADDRESSES = 8; // 0x8
		field public static final int MAP_ADDRESSES = 8; // 0x8
		field public static final int PHONE_NUMBERS = 4; // 0x4
		field public static final int WEB_URLS = 1; // 0x1
		field public static final android.text.util.Linkify.MatchFilter sPhoneNumberMatchFilter;
		@@ -52649,7 +52649,7 @@ package android.webkit {
		method public void documentHasImages(android.os.Message);
		method public static void enableSlowWholeDocumentDraw();
		method public void evaluateJavascript(java.lang.String, android.webkit.ValueCallback<java.lang.String>);
		method public static deprecated java.lang.String findAddress(java.lang.String);
		method public static java.lang.String findAddress(java.lang.String);
		method public deprecated int findAll(java.lang.String);
		method public void findAllAsync(java.lang.String);
		method public void findNext(boolean);

api/test-current.txt

+2 −2

Original line number	Diff line number	Diff line
		@@ -42934,7 +42934,7 @@ package android.text.util {
		method public static final boolean addLinks(android.text.Spannable, java.util.regex.Pattern, java.lang.String, java.lang.String[], android.text.util.Linkify.MatchFilter, android.text.util.Linkify.TransformFilter);
		field public static final int ALL = 15; // 0xf
		field public static final int EMAIL_ADDRESSES = 2; // 0x2
		field public static final deprecated int MAP_ADDRESSES = 8; // 0x8
		field public static final int MAP_ADDRESSES = 8; // 0x8
		field public static final int PHONE_NUMBERS = 4; // 0x4
		field public static final int WEB_URLS = 1; // 0x1
		field public static final android.text.util.Linkify.MatchFilter sPhoneNumberMatchFilter;
		@@ -49354,7 +49354,7 @@ package android.webkit {
		method public void documentHasImages(android.os.Message);
		method public static void enableSlowWholeDocumentDraw();
		method public void evaluateJavascript(java.lang.String, android.webkit.ValueCallback<java.lang.String>);
		method public static deprecated java.lang.String findAddress(java.lang.String);
		method public static java.lang.String findAddress(java.lang.String);
		method public deprecated int findAll(java.lang.String);
		method public void findAllAsync(java.lang.String);
		method public void findNext(boolean);

core/java/android/text/util/Linkify.java

+0 −4

Original line number	Diff line number	Diff line
		@@ -88,11 +88,7 @@ public class Linkify {
		* {@link android.webkit.WebView#findAddress(String) findAddress()} method in
		* {@link android.webkit.WebView} for finding addresses, which has various
		* limitations.
		*
		* @deprecated See {@link android.webkit.WebView#findAddress(String) findAddress()}
		* for more explanation.
		*/
		@Deprecated
		public static final int MAP_ADDRESSES = 0x08;

		/**

core/java/android/webkit/WebView.java

+0 −7

Original line number	Diff line number	Diff line
		@@ -1731,14 +1731,7 @@ public class WebView extends AbsoluteLayout
		*
		* @param addr the string to search for addresses
		* @return the address, or if no address is found, null
		*
		* @deprecated findAddress is deprecated. It only supports a subset of US
		* addresses and has a high false positive rate. Calling findAddress also causes
		* WebView to be loaded into the app, which significantly increases memory usage
		* if the app doesn't already use WebView. Use {@link TextClassifier} instead for
		* classifying text and finding addresses.
		*/
		@Deprecated
		public static String findAddress(String addr) {
		// TODO: Rewrite this in Java so it is not needed to start up chromium
		// Could also be deprecated