Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ef77d3d authored by Jeremy Joslin's avatar Jeremy Joslin
Browse files

Remove NetworkScorerAppManager.isCallerActiveScorer().

The method is no longer used.

Test: adb shell am instrument -e class android.net.NetworkScorerAppManagerTest -w com.android.frameworks.coretests/android.support.test.runner.AndroidJUnitRunner
Bug: 33781558
Change-Id: I2b4acd54a747bd480a4a91bac424d39e264ea882
parent 0ae1a7d9
Loading
Loading
Loading
Loading
+0 −10
Original line number Diff line number Diff line
@@ -226,16 +226,6 @@ public class NetworkScorerAppManager {
        return false;
    }

    /** Determine whether the application with the given UID is the enabled scorer. */
    @Deprecated // Use NetworkScoreManager.isCallerActiveScorer()
    public boolean isCallerActiveScorer(int callingUid) {
        NetworkScorerAppData defaultApp = getActiveScorer();
        if (defaultApp == null) {
            return false;
        }
        return callingUid == defaultApp.packageUid;
    }

    private boolean isNetworkRecommendationsDisabled() {
        final ContentResolver cr = mContext.getContentResolver();
        // A value of 1 indicates enabled.
+0 −19
Original line number Diff line number Diff line
@@ -169,25 +169,6 @@ public class NetworkScorerAppManagerTest extends InstrumentationTestCase {
        assertNull(activeScorer);
    }

    public void testIsCallerActiveScorer_providerNotAvailable() throws Exception {
        ContentResolver cr = mTargetContext.getContentResolver();
        Settings.Global.putInt(cr, Settings.Global.NETWORK_RECOMMENDATIONS_ENABLED, 1);

        assertFalse(mNetworkScorerAppManager.isCallerActiveScorer(924));
    }

    public void testIsCallerActiveScorer_providerAvailable() throws Exception {
        setNetworkRecommendationPackageNames("package1");
        mockScoreNetworksGranted("package1");
        mockRecommendationServiceAvailable("package1", 924 /* packageUid */);

        ContentResolver cr = mTargetContext.getContentResolver();
        Settings.Global.putInt(cr, Settings.Global.NETWORK_RECOMMENDATIONS_ENABLED, 1);

        assertTrue(mNetworkScorerAppManager.isCallerActiveScorer(924));
        assertFalse(mNetworkScorerAppManager.isCallerActiveScorer(925));
    }

    private void setNetworkRecommendationPackageNames(String... names) {
        if (names == null) {
            names = new String[0];