Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ece2f32 authored by Jason Sams's avatar Jason Sams
Browse files

Fix free after use with createFromBitmapResource 

Bug 9227350

Change-Id: Iee7610a9bf3d9d1baf14b968aed2a7d0876d2af7
parent 0dc7891c

graphics/java/android/renderscript/Allocation.java

+4 −1
Original line number Diff line number Diff line
@@ -1650,6 +1650,9 @@ public class Allocation extends BaseObj { 
                                                      int usage) {



        rs.validate();

        if ((usage & (USAGE_SHARED | USAGE_IO_INPUT | USAGE_IO_OUTPUT)) != 0) {

            throw new RSIllegalArgumentException("Unsupported usage specified.");

        }

        Bitmap b = BitmapFactory.decodeResource(res, id);

        Allocation alloc = createFromBitmap(rs, b, mips, usage);

        b.recycle();
@@ -1677,7 +1680,7 @@ public class Allocation extends BaseObj { 
        if (rs.getApplicationContext().getApplicationInfo().targetSdkVersion >= 18) {

            return createFromBitmapResource(rs, res, id,

                                            MipmapControl.MIPMAP_NONE,

                                            USAGE_SHARED | USAGE_SCRIPT | USAGE_GRAPHICS_TEXTURE);

                                            USAGE_SCRIPT | USAGE_GRAPHICS_TEXTURE);

        }

        return createFromBitmapResource(rs, res, id,

                                        MipmapControl.MIPMAP_NONE,