Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e80b60e authored by Adrian Roos's avatar Adrian Roos
Browse files

PIP: Partial fix to wrong insets during bounds animation 

Partially fixes an issue where the bounds animation when
expanding / collapsing the PIP menu would case the insets
to get wrongly applied.

The same thing still happens when animating from collapsed
to fullscreen, which requires a larger fix.

Bug: 77802617
Test: Enable cutout, enter PIP, tap on PIP window, verify transition is not jumpy.
Change-Id: I3edb4f8dec10ed85963853fa7e69812dfb198273
parent a8c840c4

services/core/java/com/android/server/am/ActivityStackSupervisor.java

+2 −4
Original line number Diff line number Diff line
@@ -2890,10 +2890,8 @@ public class ActivityStackSupervisor extends ConfigurationContainer implements D 
        try {

            ActivityRecord r = stack.topRunningActivityLocked();

            Rect insetBounds = null;

            if (tempPinnedTaskBounds != null) {

                // We always use 0,0 as the position for the inset rect because

                // if we are getting insets at all in the pinned stack it must mean

                // we are headed for fullscreen.

            if (tempPinnedTaskBounds != null && stack.isAnimatingBoundsToFullscreen()) {

                // Use 0,0 as the position for the inset rect because we are headed for fullscreen.

                insetBounds = tempRect;

                insetBounds.top = 0;

                insetBounds.left = 0;