Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e2e1ae4 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Clean up TODOs in statsd"

parents 93fae901 5bfffb54

cmds/statsd/Android.mk

+1 −1
Original line number Diff line number Diff line
@@ -71,7 +71,7 @@ statsd_common_src := \ 
    src/guardrail/StatsdStats.cpp \

    src/socket/StatsSocketListener.cpp



# TODO: Once statsd is using a blueprint file, migrate to the proper filegroups.

# TODO(b/110563449): Once statsd is using a blueprint file, migrate to the proper filegroups.

statsd_common_src += \

    ../../../../system/extras/perfprofd/binder_interface/aidl/android/os/IPerfProfd.aidl \

    src/perfprofd/perfprofd_config.proto

cmds/statsd/src/FieldValue.h

+1 −1
Original line number Diff line number Diff line
@@ -212,7 +212,7 @@ public: 
 * the result is equal to the Matcher Field. That's a bit wise AND operation + check if 2 ints are

 * equal. Nothing can beat the performance of this matching algorithm.

 *

 * TODO: ADD EXAMPLE HERE.

 * TODO(b/110561213): ADD EXAMPLE HERE.

 */

struct Matcher {

    Matcher(const Field& matcher, int32_t mask) : mMatcher(matcher), mMask(mask){};

cmds/statsd/src/HashableDimensionKey.cpp

+1 −3
Original line number Diff line number Diff line
@@ -65,8 +65,6 @@ bool filterValues(const vector<Matcher>& matcherFields, const vector<FieldValue> 
    for (const auto& value : values) {

        for (size_t i = 0; i < matcherFields.size(); ++i) {

            const auto& matcher = matcherFields[i];

            // TODO: potential optimization here to break early because all fields are naturally

            // sorted.

            if (value.mField.matches(matcher)) {

                output->addValue(value);

                output->mutableValue(num_matches)->mField.setTag(value.mField.getTag());

cmds/statsd/src/StatsService.cpp

+0 −4
Original line number Diff line number Diff line
@@ -440,7 +440,6 @@ status_t StatsService::cmd_trigger_broadcast(FILE* out, Vector<String8>& args) { 
    if (argCount == 2) {

        // Automatically pick the UID

        uid = IPCThreadState::self()->getCallingUid();

        // TODO: What if this isn't a binder call? Should we fail?

        name.assign(args[1].c_str(), args[1].size());

        good = true;

    } else if (argCount == 3) {
@@ -493,7 +492,6 @@ status_t StatsService::cmd_config(FILE* in, FILE* out, FILE* err, Vector<String8 
            if (argCount == 3) {

                // Automatically pick the UID

                uid = IPCThreadState::self()->getCallingUid();

                // TODO: What if this isn't a binder call? Should we fail?

                name.assign(args[2].c_str(), args[2].size());

                good = true;

            } else if (argCount == 4) {
@@ -578,7 +576,6 @@ status_t StatsService::cmd_dump_report(FILE* out, FILE* err, const Vector<String 
        if (argCount == 2) {

            // Automatically pick the UID

            uid = IPCThreadState::self()->getCallingUid();

            // TODO: What if this isn't a binder call? Should we fail?

            name.assign(args[1].c_str(), args[1].size());

            good = true;

        } else if (argCount == 3) {
@@ -604,7 +601,6 @@ status_t StatsService::cmd_dump_report(FILE* out, FILE* err, const Vector<String 
            vector<uint8_t> data;

            mProcessor->onDumpReport(ConfigKey(uid, StrToInt64(name)), getElapsedRealtimeNs(),

                                     false /* include_current_bucket*/, ADB_DUMP, &data);

            // TODO: print the returned StatsLogReport to file instead of printing to logcat.

            if (proto) {

                for (size_t i = 0; i < data.size(); i ++) {

                    fprintf(out, "%c", data[i]);

cmds/statsd/src/StatsService.h

+0 −1
Original line number Diff line number Diff line
@@ -49,7 +49,6 @@ public: 
    virtual ~StatsService();



    /** The anomaly alarm registered with AlarmManager won't be updated by less than this. */

    // TODO: Consider making this configurable. And choose a good number.

    const uint32_t MIN_DIFF_TO_UPDATE_REGISTERED_ALARM_SECS = 5;



    virtual status_t onTransact(uint32_t code, const Parcel& data, Parcel* reply, uint32_t flags);