Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e181b1e authored by Brad Hinegardner's avatar Brad Hinegardner
Browse files

Remove stateIn from buttons in shortcuts combined view model 

This stateIn appears to be preventing the shortcuts from being updated
after the device is unlocked the first time. Adjusting the `started` to
`WhileSubscribed()` was adjusted to `Eagerly` to mitigate an issue with
wallet.

It is best to just remove this stateIn for now to retain functionality.
Further attempts to cut down on coroutine continuations can be made at
a later time.

Fixes: 366370507
Test: manual - reboot phone with shortcuts on LS, unlock and observe shortcuts show up
Flag: EXEMPT bugfix
Change-Id: I74e8e7751e938dd587a9ab435ebfb128723e0241
parent 97344c76

packages/SystemUI/src/com/android/systemui/keyguard/ui/viewmodel/KeyguardQuickAffordancesCombinedViewModel.kt

+0 −16
Original line number Diff line number Diff line
@@ -179,14 +179,6 @@ constructor( 
        } else {

            button(KeyguardQuickAffordancePosition.BOTTOM_START)

        }

        .stateIn(

            scope = applicationScope,

            started = SharingStarted.Eagerly,

            initialValue =

                KeyguardQuickAffordanceViewModel(

                    slotId = KeyguardQuickAffordancePosition.BOTTOM_START.toSlotId()

                ),

        )



    /** An observable for the view-model of the "end button" quick affordance. */

    val endButton: Flow<KeyguardQuickAffordanceViewModel> =
@@ -200,14 +192,6 @@ constructor( 
        } else {

            button(KeyguardQuickAffordancePosition.BOTTOM_END)

        }

        .stateIn(

            scope = applicationScope,

            started = SharingStarted.Eagerly,

            initialValue =

                KeyguardQuickAffordanceViewModel(

                    slotId = KeyguardQuickAffordancePosition.BOTTOM_END.toSlotId()

                ),

        )



    /**

     * Notifies that a slot with the given ID has been selected in the preview experience that is