Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3d94ad46 authored by Lingyu Feng's avatar Lingyu Feng
Browse files

Prevent toast being shown on a display that cannot host tasks 

When a connected display is mirroring, Display.canHostTask() returns
false. In this CL, if a toast widget's target display is mirroring, it
will instead be shown on the default display.

Bug: 417098352
Flag: com.android.window.flags.enable_mirror_display_no_activity
Test: presubmit
Change-Id: I800b527537314dce8245c2fb9ba8c90d59096a07
parent 94ccf8b9

services/core/java/com/android/server/notification/NotificationManagerService.java

+20 −2
Original line number Diff line number Diff line
@@ -278,6 +278,7 @@ import android.content.pm.VersionedPackage; 
import android.content.res.Resources;

import android.database.ContentObserver;

import android.graphics.drawable.Icon;

import android.hardware.display.DisplayManager;

import android.metrics.LogMaker;

import android.net.Uri;

import android.os.Binder;
@@ -334,6 +335,8 @@ import android.service.notification.ZenModeProto; 
import android.service.notification.ZenPolicy;

import android.telecom.TelecomManager;

import android.telephony.TelephonyManager;

import android.text.Annotation;

import android.text.Spanned;

import android.text.TextUtils;

import android.text.format.DateUtils;

import android.util.ArrayMap;
@@ -352,8 +355,7 @@ import android.view.Display; 
import android.view.accessibility.AccessibilityManager;

import android.widget.RemoteViews;

import android.widget.Toast;

import android.text.Spanned;

import android.text.Annotation;

import android.window.DesktopExperienceFlags;















import com.android.internal.R;















import com.android.internal.annotations.GuardedBy;










@@ -683,6 +685,7 @@ public class NotificationManagerService extends SystemService {



























    // Can be null for wear















    @Nullable StatusBarManagerInternal mStatusBar;













    private DisplayManager mDisplayManager;















    private WindowManagerInternal mWindowManagerInternal;















    private AlarmManager mAlarmManager;















    @VisibleForTesting










@@ -3466,6 +3469,7 @@ public class NotificationManagerService extends SystemService {













    @VisibleForTesting















    void onBootPhase(int phase, Looper mainLooper) {















        if (phase == SystemService.PHASE_SYSTEM_SERVICES_READY) {













            mDisplayManager = getContext().getSystemService(DisplayManager.class);















            mWindowManagerInternal = LocalServices.getService(WindowManagerInternal.class);















            mZenModeHelper.onSystemReady();















            RoleObserver roleObserver = new RoleObserver(getContext(),










@@ -4159,6 +4163,20 @@ public class NotificationManagerService extends SystemService {













                }















            }



























            // If the display cannot host tasks (such as a display used for mirroring), show the













            // toast on default display instead.













            if (DesktopExperienceFlags.ENABLE_MIRROR_DISPLAY_NO_ACTIVITY.isTrue()) {













                Display display = mDisplayManager.getDisplay(displayId);













                if (display != null && !display.canHostTasks()) {













                    if (DBG) {













                        Slogf.d(TAG, "Changing display id from %d to %d, because display %d "













                                        + "cannot host tasks",













                                displayId, Display.DEFAULT_DISPLAY, displayId);













                    }













                    displayId = Display.DEFAULT_DISPLAY;













                }













            }



























            checkCallerIsSameApp(pkg);















            final boolean isSystemToast = isCallerSystemOrSystemUi()















                    || PackageManagerService.PLATFORM_PACKAGE_NAME.equals(pkg);