Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3d1050f4 authored by Steven Moreland's avatar Steven Moreland
Browse files

libandroid_runtime: RefBase strict mode 

Use ANDROID_UTILS_REF_BASE_DISABLE_IMPLICIT_CONSTRUCTION.

Enabling this on our core JNI code, to expand best practice, and
hopefully catch some hard to reproduce bugs.

Bug: 393013610
Test: (this is enabling a compiler check)
Change-Id: I85e19b24e3c628960158c25a36c8178529dd7b79
parent 15f30d11

core/jni/Android.bp

+2 −0
Original line number Diff line number Diff line
@@ -42,6 +42,8 @@ cc_library_shared_for_libandroid_runtime { 


        "-DU_USING_ICU_NAMESPACE=0",



        "-DANDROID_UTILS_REF_BASE_DISABLE_IMPLICIT_CONSTRUCTION",



        "-Wall",

        "-Werror",

        "-Wextra",

core/jni/android_content_res_ObbScanner.cpp

+1 −0
Original line number Diff line number Diff line
@@ -13,6 +13,7 @@ 
 * See the License for the specific language governing permissions and

 * limitations under the License.

 */

#undef ANDROID_UTILS_REF_BASE_DISABLE_IMPLICIT_CONSTRUCTION // TODO:remove this and fix code



#define LOG_TAG "ObbScanner"

core/jni/android_graphics_BLASTBufferQueue.cpp

+1 −0
Original line number Diff line number Diff line
@@ -13,6 +13,7 @@ 
 * See the License for the specific language governing permissions and

 * limitations under the License.

 */

#undef ANDROID_UTILS_REF_BASE_DISABLE_IMPLICIT_CONSTRUCTION // TODO:remove this and fix code



#define LOG_TAG "BLASTBufferQueue"

core/jni/android_graphics_GraphicBuffer.cpp

+1 −0
Original line number Diff line number Diff line
@@ -13,6 +13,7 @@ 
 * See the License for the specific language governing permissions and

 * limitations under the License.

 */

#undef ANDROID_UTILS_REF_BASE_DISABLE_IMPLICIT_CONSTRUCTION // TODO:remove this and fix code



#define LOG_TAG "GraphicBuffer"

core/jni/android_graphics_SurfaceTexture.cpp

+1 −0
Original line number Diff line number Diff line
@@ -13,6 +13,7 @@ 
 * See the License for the specific language governing permissions and

 * limitations under the License.

 */

#undef ANDROID_UTILS_REF_BASE_DISABLE_IMPLICIT_CONSTRUCTION // TODO:remove this and fix code



#undef LOG_TAG

#define LOG_TAG "SurfaceTexture"