Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ccd2488 authored by Prabir Pradhan's avatar Prabir Pradhan
Browse files

Revert "Use SOURCE_CLASS_POINTER as the default source for MotionEvent" 

This reverts commit b1d3e076.

Reason for revert: Breaking CarUiRecyclerViewTest#testThumbDragToCenter tests

Bug: 211051185
Bug: 211051850
Bug: 213425347

Change-Id: Ia8e5c2301ab389a4e9b436165157f8918d285649
parent 4d6ea2fb

core/java/android/view/MotionEvent.java

+1 −1
Original line number Diff line number Diff line
@@ -1872,7 +1872,7 @@ public final class MotionEvent extends InputEvent implements Parcelable { 
            float x, float y, float pressure, float size, int metaState,

            float xPrecision, float yPrecision, int deviceId, int edgeFlags) {

        return obtain(downTime, eventTime, action, x, y, pressure, size, metaState,

                xPrecision, yPrecision, deviceId, edgeFlags, InputDevice.SOURCE_CLASS_POINTER,

                xPrecision, yPrecision, deviceId, edgeFlags, InputDevice.SOURCE_UNKNOWN,

                DEFAULT_DISPLAY);

    }

core/tests/coretests/src/android/view/MotionEventTest.java

+0 −24
Original line number Diff line number Diff line
@@ -16,7 +16,6 @@ 


package android.view;



import static android.view.InputDevice.SOURCE_CLASS_POINTER;

import static android.view.MotionEvent.ACTION_DOWN;

import static android.view.MotionEvent.ACTION_POINTER_DOWN;

import static android.view.MotionEvent.TOOL_TYPE_FINGER;
@@ -215,27 +214,4 @@ public class MotionEventTest { 
        rotInvalid.transform(mat);

        assertEquals(-1, rotInvalid.getSurfaceRotation());

    }



    @Test

    public void testUsesPointerSourceByDefault() {

        final MotionEvent event = MotionEvent.obtain(0 /* downTime */, 0 /* eventTime */,

                ACTION_DOWN, 0 /* x */, 0 /* y */, 0 /* metaState */);

        assertTrue(event.isFromSource(SOURCE_CLASS_POINTER));

    }



    @Test

    public void testLocationOffsetOnlyAppliedToNonPointerSources() {

        final MotionEvent event = MotionEvent.obtain(0 /* downTime */, 0 /* eventTime */,

                ACTION_DOWN, 10 /* x */, 20 /* y */, 0 /* metaState */);

        event.offsetLocation(40, 50);



        // The offset should be applied since a pointer source is used by default.

        assertEquals(50, (int) event.getX());

        assertEquals(70, (int) event.getY());



        // The offset should not be applied if the source is changed to a non-pointer source.

        event.setSource(InputDevice.SOURCE_JOYSTICK);

        assertEquals(10, (int) event.getX());

        assertEquals(20, (int) event.getY());

    }

}