Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3c8c6a4c authored by Peng Xu's avatar Peng Xu
Browse files

Address review suggestions for sensor direct report related APIs 

Changes inline with bug number

Some improvements about SensorDirectChannel class.
  * Complete the doc about creation of SensorDirectChannel object.
  * Make SensorDirectChannel implements java.nio.channels.Channel.
  * Change isValid() to isOpen().
  * Make close() thread safe.
Bug: 36550285

  * Throw exception on failure of SensorManager.createDirectChannel.
  * Change to use NullPointerException when unexpected null pointer
    is passed in.
Bug: 36555061

  * Move SensorManager.configureDirectChannel() to
    SensorDirectChannel.configure().
  * Format SensorDirectChannel.configure() function doc with
    <pre></pre> to maintain the table structure.
  * Reworded Sensor.isDirectChannelTypeSupported java doc.
Bug: 36555604

Test: pass updated cts SensorDirectReportTest
Change-Id: I447121eaf414cbc94292a109a9d93d2e3c89f8f4
parent d09be1c0

api/current.txt

+4 −4
Original line number Diff line number Diff line
@@ -14864,15 +14864,16 @@ package android.hardware { 
    field public final int type;

  }













  public final class SensorDirectChannel implements java.lang.AutoCloseable {













  public final class SensorDirectChannel implements java.nio.channels.Channel {















    method public void close();













    method public boolean isValid();













    method public int configure(android.hardware.Sensor, int);













    method public boolean isOpen();















    field public static final int RATE_FAST = 2; // 0x2















    field public static final int RATE_NORMAL = 1; // 0x1















    field public static final int RATE_STOP = 0; // 0x0















    field public static final int RATE_VERY_FAST = 3; // 0x3













    field public static final int TYPE_ASHMEM = 1; // 0x1















    field public static final int TYPE_HARDWARE_BUFFER = 2; // 0x2













    field public static final int TYPE_MEMORY_FILE = 1; // 0x1















  }





























  public class SensorEvent {










@@ -14906,7 +14907,6 @@ package android.hardware {



























  public abstract class SensorManager {















    method public boolean cancelTriggerSensor(android.hardware.TriggerEventListener, android.hardware.Sensor);













    method public int configureDirectChannel(android.hardware.SensorDirectChannel, android.hardware.Sensor, int);















    method public android.hardware.SensorDirectChannel createDirectChannel(android.os.MemoryFile);















    method public android.hardware.SensorDirectChannel createDirectChannel(android.hardware.HardwareBuffer);















    method public boolean flush(android.hardware.SensorEventListener);

























api/removed.txt



+12
−0




























Original line number
Diff line number
Diff line








@@ -100,6 +100,18 @@ package android.graphics {





























}





























package android.hardware {



























  public final class SensorDirectChannel implements java.nio.channels.Channel {













    method public deprecated boolean isValid();













  }



























  public abstract class SensorManager {













    method public deprecated int configureDirectChannel(android.hardware.SensorDirectChannel, android.hardware.Sensor, int);













  }



























}





























package android.media {































  public final class AudioFormat implements android.os.Parcelable {

































api/system-current.txt



+4
−4




























Original line number
Diff line number
Diff line








@@ -15637,15 +15637,16 @@ package android.hardware {













    field public final int type;















  }



























  public final class SensorDirectChannel implements java.lang.AutoCloseable {













  public final class SensorDirectChannel implements java.nio.channels.Channel {















    method public void close();













    method public boolean isValid();













    method public int configure(android.hardware.Sensor, int);













    method public boolean isOpen();















    field public static final int RATE_FAST = 2; // 0x2















    field public static final int RATE_NORMAL = 1; // 0x1















    field public static final int RATE_STOP = 0; // 0x0















    field public static final int RATE_VERY_FAST = 3; // 0x3













    field public static final int TYPE_ASHMEM = 1; // 0x1















    field public static final int TYPE_HARDWARE_BUFFER = 2; // 0x2













    field public static final int TYPE_MEMORY_FILE = 1; // 0x1















  }





























  public class SensorEvent {










@@ -15679,7 +15680,6 @@ package android.hardware {



























  public abstract class SensorManager {















    method public boolean cancelTriggerSensor(android.hardware.TriggerEventListener, android.hardware.Sensor);













    method public int configureDirectChannel(android.hardware.SensorDirectChannel, android.hardware.Sensor, int);















    method public android.hardware.SensorDirectChannel createDirectChannel(android.os.MemoryFile);















    method public android.hardware.SensorDirectChannel createDirectChannel(android.hardware.HardwareBuffer);















    method public boolean flush(android.hardware.SensorEventListener);

























api/system-removed.txt



+12
−0




























Original line number
Diff line number
Diff line








@@ -98,6 +98,18 @@ package android.graphics {





























}





























package android.hardware {



























  public final class SensorDirectChannel implements java.nio.channels.Channel {













    method public deprecated boolean isValid();













  }



























  public abstract class SensorManager {













    method public deprecated int configureDirectChannel(android.hardware.SensorDirectChannel, android.hardware.Sensor, int);













  }



























}





























package android.media {































  public final class AudioFormat implements android.os.Parcelable {

































api/test-current.txt



+4
−4




























Original line number
Diff line number
Diff line








@@ -14918,15 +14918,16 @@ package android.hardware {













    field public final int type;















  }



























  public final class SensorDirectChannel implements java.lang.AutoCloseable {













  public final class SensorDirectChannel implements java.nio.channels.Channel {















    method public void close();













    method public boolean isValid();













    method public int configure(android.hardware.Sensor, int);













    method public boolean isOpen();















    field public static final int RATE_FAST = 2; // 0x2















    field public static final int RATE_NORMAL = 1; // 0x1















    field public static final int RATE_STOP = 0; // 0x0















    field public static final int RATE_VERY_FAST = 3; // 0x3













    field public static final int TYPE_ASHMEM = 1; // 0x1















    field public static final int TYPE_HARDWARE_BUFFER = 2; // 0x2













    field public static final int TYPE_MEMORY_FILE = 1; // 0x1















  }





























  public class SensorEvent {










@@ -14960,7 +14961,6 @@ package android.hardware {



























  public abstract class SensorManager {















    method public boolean cancelTriggerSensor(android.hardware.TriggerEventListener, android.hardware.Sensor);













    method public int configureDirectChannel(android.hardware.SensorDirectChannel, android.hardware.Sensor, int);















    method public android.hardware.SensorDirectChannel createDirectChannel(android.os.MemoryFile);















    method public android.hardware.SensorDirectChannel createDirectChannel(android.hardware.HardwareBuffer);















    method public boolean flush(android.hardware.SensorEventListener);