Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 3c102221 authored by Caitlin Shkuratov's avatar Caitlin Shkuratov
Browse files

[CS] 2/4: Have NotificationLogger listen to shade/LS visibility directly

Removes some CentralSurfaces logic by having NotificationLogger listen
directly to WindowRootViewVisibilityInteractor instead of requiring
CentralSurfaces to notify NotificationLogger.

Also removes some NotificationLogger internal logic around starting &
stopping logging. When I added some debug logging, the CentralSurfaces
calls to start/stop logging were *always* happening at the same cadence
as the internal NotificationLogger tracking. So, I removed the internal
tracking to have NotificationLogger use only one source of truth.

Bug: 296050180
Test: manual: verified via logging that notif logging starts when device
wakes to lockscreen or when shade is pulled down while unlocked.
Verified notif logging stops when on bouncer, device is unlocked, or
device goes to sleep.
Test: atest NotificationLoggerTest CentralSurfacesImplTest

Change-Id: Id05ddf681d42b5185517faf2689761ac36bfff8a
parent eb73eca1
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment