Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3b12be13 authored by Shen Lin's avatar Shen Lin
Browse files

Fix potential NPE when preference is null 

findPreference is a nullable method so we need a null-check before calling its method.

Bug: 253904634
Test: atest
Change-Id: I497ba76a61b19bab9602849f1aef725829193ff2
parent d01036ee

packages/SettingsLib/src/com/android/settingslib/core/AbstractPreferenceController.java

+4 −2
Original line number Diff line number Diff line
@@ -41,9 +41,11 @@ public abstract class AbstractPreferenceController { 
            setVisible(screen, prefKey, true /* visible */);

            if (this instanceof Preference.OnPreferenceChangeListener) {

                final Preference preference = screen.findPreference(prefKey);

                if (preference != null) {

                    preference.setOnPreferenceChangeListener(

                            (Preference.OnPreferenceChangeListener) this);

                }

            }

        } else {

            setVisible(screen, prefKey, false /* visible */);

        }