Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3aeea1f2 authored by Christopher Tate's avatar Christopher Tate
Browse files

System package permission decls take precedence over 3rd party apps' 

In particular, if a 3rd party app tries to define a permission that
turns out to be defined by system packages following an upgrade,
the system package gets ownership and grants are re-evaluated
on that basis.

Bug 11242510

Change-Id: Id3a2b53d52750c629414cd8226e33e5e03dd0c54
parent 8869d6f3

services/java/com/android/server/pm/PackageManagerService.java

+12 −0
Original line number Diff line number Diff line
@@ -4959,6 +4959,18 @@ public class PackageManagerService extends IPackageManager.Stub { 
                        permissionMap.put(p.info.name, bp);

                    }

                    if (bp.perm == null) {

                        if (bp.sourcePackage != null

                                && !bp.sourcePackage.equals(p.info.packageName)) {

                            // If this is a permission that was formerly defined by a non-system

                            // app, but is now defined by a system app (following an upgrade),

                            // discard the previous declaration and consider the system's to be

                            // canonical.

                            if (isSystemApp(p.owner)) {

                                Slog.i(TAG, "New decl " + p.owner + " of permission  "

                                        + p.info.name + " is system");

                                bp.sourcePackage = null;

                            }

                        }

                        if (bp.sourcePackage == null

                                || bp.sourcePackage.equals(p.info.packageName)) {

                            BasePermission tree = findPermissionTreeLP(p.info.name);