Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ac2e435 authored by Rachel Lee's avatar Rachel Lee
Browse files

Add check for empty vsync data in Choreographer. 

Currently there is a codepath in native DisplayEventDispatcher
introduced by aosp fc690e2a2d1d3cf08d71a02c4ecd14665c0f2039.
It accounts for vsync timeout. Here in java choreographer, we don't want
to divide by zero for logging messages so a check is added. There are no
real logic changes.

Test: atest ChoreographerTest
Bug: 229685140
Change-Id: I80f24abb89b9d961b017aca93340b1b02af6f66c
parent b88d3d47

core/java/android/view/Choreographer.java

+17 −11
Original line number Diff line number Diff line
@@ -765,18 +765,24 @@ public final class Choreographer { 
                startNanos = System.nanoTime();

                final long jitterNanos = startNanos - frameTimeNanos;

                if (jitterNanos >= frameIntervalNanos) {

                    final long lastFrameOffset = jitterNanos % frameIntervalNanos;

                    if (frameIntervalNanos == 0) {

                        Log.i(TAG, "Vsync data empty due to timeout");

                    } else {

                        final long skippedFrames = jitterNanos / frameIntervalNanos;

                        if (skippedFrames >= SKIPPED_FRAME_WARNING_LIMIT) {

                            Log.i(TAG, "Skipped " + skippedFrames + " frames!  "

                                + "The application may be doing too much work on its main thread.");

                                    + "The application may be doing too much work on its main "

                                    + "thread.");

                        }

                    final long lastFrameOffset = jitterNanos % frameIntervalNanos;

                        if (DEBUG_JANK) {

                            Log.d(TAG, "Missed vsync by " + (jitterNanos * 0.000001f) + " ms "

                                    + "which is more than the frame interval of "

                                    + (frameIntervalNanos * 0.000001f) + " ms!  "

                                    + "Skipping " + skippedFrames + " frames and setting frame "

                                + "time to " + (lastFrameOffset * 0.000001f) + " ms in the past.");

                                    + "time to " + (lastFrameOffset * 0.000001f)

                                    + " ms in the past.");

                        }

                    }

                    frameTimeNanos = startNanos - lastFrameOffset;

                    DisplayEventReceiver.VsyncEventData latestVsyncEventData =