Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 3abfc4d5 authored by Caitlin Shkuratov's avatar Caitlin Shkuratov
Browse files

[SB][Notif] Don't allow call notif to also show in a promoted notif chip

Currently if an app posts a notification with CallStyle.Ongoing that
*also* meets the promoted notification criteria, the status bar would
incorrectly show 2 chips for the same notification: One because it's a
call, and another because it's promoted.

This CL:
1) Filters out call notifications from promoted notifications so there
   won't be duplicate chips. (Call notifications need to take priority
   over promoted notifications, which is why I'm keeping the call
   notification Flow the same and doing the filtering on the other
   Flow.)
2) Updates the call chip to use the notification's coloring if the call
   notification also matches the promotion criteria. This makes the call
   chip look like a promoted notification chip, while ensuring the call
   chip still always shows the 00:01 timer.

Fixes: 388521980
Bug: 364653005
Flag: com.android.systemui.status_bar_notification_chips

Test: Post a CallStyle.Ongoing notification that's also colorized & has
FLAG_ONGOING_EVENT set -> verify only a single chip is shown. Verify
that chip uses the notification color, not the theme color.
Test: Post a CallStyle.Ongoing notification and a different promoted
notification -> verify call chip is shown first

Change-Id: I67427a4c8aa4b0d0890f9ef621e56aa87cf67b64
parent 77fb9ee0
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment