Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3aba8530 authored by Harry Cutts's avatar Harry Cutts
Browse files

input: clean up bug report shortcut flag 

Bug: 409611706
Test: m checkinput
Flag: EXEMPT removing
      com.android.server.flags.new_bugreport_keyboard_shortcut

Change-Id: Icf2eb471619f4860bb11d13bf54529487d0da0be
parent 9a5663fe

services/core/java/com/android/server/flags/services.aconfig

+0 −10
Original line number Diff line number Diff line 
package: "com.android.server.flags"

container: "system"



flag {

    namespace: "input"

    name: "new_bugreport_keyboard_shortcut"

    description: "Enable META+CTRL+BACKSPACE keyboard shortcut for taking a bug report"

    bug: "335607520"

    metadata {

        purpose: PURPOSE_BUGFIX

    }

}



flag {

    namespace: "backstage_power"

    name: "pkg_targeted_battery_changed_not_sticky"

services/core/java/com/android/server/input/InputGestureManager.java

+1 −2
Original line number Diff line number Diff line
@@ -21,7 +21,6 @@ import static android.hardware.input.InputGestureData.createKeyTrigger; 
import static com.android.hardware.input.Flags.enableTalkbackAndMagnifierKeyGestures;

import static com.android.hardware.input.Flags.enableVoiceAccessKeyGestures;

import static com.android.hardware.input.Flags.keyboardA11yShortcutControl;

import static com.android.server.flags.Flags.newBugreportKeyboardShortcut;



import android.annotation.NonNull;

import android.annotation.Nullable;
@@ -178,7 +177,7 @@ final class InputGestureManager { 
                        KeyGestureEvent.KEY_GESTURE_TYPE_RECENT_APPS

                )

        ));

        if (newBugreportKeyboardShortcut() && "1".equals(SystemProperties.get("ro.debuggable"))) {

        if ("1".equals(SystemProperties.get("ro.debuggable"))) {

            systemShortcuts.add(createKeyGesture(

                    KeyEvent.KEYCODE_DEL,

                    KeyEvent.META_META_ON | KeyEvent.META_CTRL_ON,

tests/Input/src/com/android/server/input/KeyGestureControllerTests.kt

+0 −2
Original line number Diff line number Diff line
@@ -743,7 +743,6 @@ class KeyGestureControllerTests { 
    @Test

    @Parameters(method = "systemGesturesTestArguments")

    @EnableFlags(

        com.android.server.flags.Flags.FLAG_NEW_BUGREPORT_KEYBOARD_SHORTCUT,

        com.android.hardware.input.Flags.FLAG_KEYBOARD_A11Y_SHORTCUT_CONTROL,

        com.android.hardware.input.Flags.FLAG_KEYBOARD_A11Y_MOUSE_KEYS,

        com.android.hardware.input.Flags.FLAG_ENABLE_TALKBACK_AND_MAGNIFIER_KEY_GESTURES,
@@ -760,7 +759,6 @@ class KeyGestureControllerTests { 
    @Test

    @Parameters(method = "systemGesturesTestArguments")

    @EnableFlags(

        com.android.server.flags.Flags.FLAG_NEW_BUGREPORT_KEYBOARD_SHORTCUT,

        com.android.hardware.input.Flags.FLAG_KEYBOARD_A11Y_SHORTCUT_CONTROL,

        com.android.hardware.input.Flags.FLAG_KEYBOARD_A11Y_MOUSE_KEYS,

        com.android.hardware.input.Flags.FLAG_ENABLE_TALKBACK_AND_MAGNIFIER_KEY_GESTURES,