Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3a6818bb authored by Beth Thibodeau's avatar Beth Thibodeau
Browse files

Screen record UI polish 

- Fix capitalization
- Default to device audio
- Use showBigPictureWhenCollapsed instead of setting largeIcon
separately
- Update styles to inherit device default

Fixes: 185544094
Fixes: 185544175
Fixes: 186427367
Fixes: 185544265
Test: visual

Change-Id: Ic545f8bc0ef77aabaab24a4585c87c3aa29ac7f5
parent 0c59d91a

packages/SystemUI/res/values/strings.xml

+1 −1
Original line number Diff line number Diff line
@@ -989,7 +989,7 @@ 
    <string name="quick_settings_nfc_on">NFC is enabled</string>



    <!-- QuickSettings: Screen record tile [CHAR LIMIT=NONE] -->

    <string name="quick_settings_screen_record_label">Screen Record</string>

    <string name="quick_settings_screen_record_label">Screen record</string>

    <!-- QuickSettings: Text to prompt the user to begin a new recording [CHAR LIMIT=20] -->

    <string name="quick_settings_screen_record_start">Start</string>

    <!-- QuickSettings: Text to prompt the user to stop an ongoing recording [CHAR LIMIT=20] -->

packages/SystemUI/res/values/styles.xml

+2 −1
Original line number Diff line number Diff line
@@ -682,7 +682,8 @@ 
    </style>



    <!-- Screen recording -->

    <style name="ScreenRecord" parent="Theme.SystemUI.Dialog.GlobalActions">

    <style name="ScreenRecord" parent="@android:style/Theme.DeviceDefault.DayNight">

        <item name="android:windowNoTitle">true</item>

        <item name="android:windowIsTranslucent">true</item>

        <item name="android:windowBackground">@android:color/transparent</item>

        <item name="android:windowIsFloating">true</item>

packages/SystemUI/src/com/android/systemui/screenrecord/RecordingService.java

+2 −2
Original line number Diff line number Diff line
@@ -367,8 +367,8 @@ public class RecordingService extends Service implements MediaRecorder.OnInfoLis 
        if (thumbnailBitmap != null) {

            Notification.BigPictureStyle pictureStyle = new Notification.BigPictureStyle()

                    .bigPicture(thumbnailBitmap)

                    .bigLargeIcon((Bitmap) null);

            builder.setLargeIcon(thumbnailBitmap).setStyle(pictureStyle);

                    .showBigPictureWhenCollapsed(true);

            builder.setStyle(pictureStyle);

        }

        return builder.build();

    }

packages/SystemUI/src/com/android/systemui/screenrecord/ScreenRecordDialog.java

+1 −1
Original line number Diff line number Diff line
@@ -90,8 +90,8 @@ public class ScreenRecordDialog extends Activity { 
        });



        mModes = new ArrayList<>();

        mModes.add(MIC);

        mModes.add(INTERNAL);

        mModes.add(MIC);

        mModes.add(MIC_AND_INTERNAL);



        mAudioSwitch = findViewById(R.id.screenrecord_audio_switch);