Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3a133327 authored by Joanne Chung's avatar Joanne Chung
Browse files

Avoid NPE crash system server 

The install request was removed from the array but another new post
to handle the same request was coming. Cannot get the request from
the array that caused NPE. There are two paths that will post
POST_INSTALL, one comes install flow, one comes from another system
services, e.g, backup, rollback. From dashboard, this should be a
rare case, the happen rate is low. To avoid crash system, do
nothing if request is null.

Bug: 321267572
Test: manual. Cannot reproduce locally
Change-Id: I3ab158a14823719478de2a20c11941ae75b6f549
parent 6bf8e9bd

services/core/java/com/android/server/pm/PackageHandler.java

+7 −0
Original line number Diff line number Diff line
@@ -88,6 +88,13 @@ final class PackageHandler extends Handler { 
                final boolean didRestore = (msg.arg2 != 0);

                mPm.mRunningInstalls.delete(msg.arg1);



                if (request == null) {

                    if (DEBUG_INSTALL) {

                        Slog.i(TAG, "InstallRequest is null. Nothing to do for post-install "

                                + "token " + msg.arg1);

                    }

                    break;

                }

                request.closeFreezer();

                request.onInstallCompleted();

                request.runPostInstallRunnable();