Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 39b3d4ca authored by Vladislav Kaznacheev's avatar Vladislav Kaznacheev
Browse files

Fix layout for menu item checkbox and submenu arrow. 

Use RelativeLayout for title and shortcut, the way it used to be
for a long time before ag/2765657.

Move the comments in the layout file to correct places.

Bug: 72712956
Test: manual
Change-Id: I3539cf1cbba67f33bd3cc9c6b81d7e946ad70bc9
parent 4307efc8

core/res/res/layout/popup_menu_item_layout.xml

+10 −9
Original line number Diff line number Diff line
@@ -28,18 +28,18 @@ 
        android:layout_marginBottom="4dip"

        android:background="@drawable/list_divider_material" />



    <!-- Icon will be inserted here. -->



    <!-- The title and summary have some gap between them,

    and this 'group' should be centered vertically. -->

    <LinearLayout

        android:id="@+id/content"

        android:layout_width="wrap_content"

        android:layout_width="match_parent"

        android:layout_height="?attr/dropdownListPreferredItemHeight"

        android:paddingEnd="16dip"

        android:duplicateParentState="true" >



        <LinearLayout

        <!-- Icon will be inserted here. -->



        <!-- The title and summary have some gap between them,

        and this 'group' should be centered vertically. -->

        <RelativeLayout

            android:layout_width="0dip"

            android:layout_weight="1"

            android:layout_height="wrap_content"
@@ -71,7 +71,7 @@ 
                android:duplicateParentState="true"

                android:textAlignment="viewStart" />



        </LinearLayout>

        </RelativeLayout>



        <ImageView

            android:id="@+id/submenuarrow"
@@ -81,8 +81,9 @@ 
            android:layout_marginStart="8dp"

            android:scaleType="center"

            android:visibility="gone" />

    </LinearLayout>



        <!-- Checkbox, and/or radio button will be inserted here. -->



    </LinearLayout>



</com.android.internal.view.menu.ListMenuItemView>