Commit 3994e991 authored Apr 02, 2025 by Siarhei Vishniakou

Dispose mPointerEventDispatcher on UiThread

The function InputEventReceiver::dispose must be called on the looper thread. This is documented in InputEventReceiver::dispose:


   /**
     * Disposes the receiver.
     * Must be called on the same Looper thread to which the receiver is attached.
     */
    public void dispose() {
        dispose(false);
    }

That expectation is not currently met in the DisplayContent code.

Update the code so that it conforms to the expectation.

This will allow us in subsequent CLs to crash whenever dispose is called on the wrong thread.

Bug: 376713684
Bug: 311142655
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: I86ffb14fee7c3e7b31a47205f84572ae640d234b

parent ca4b2104

services/core/java/com/android/server/wm/PointerEventDispatcher.java

+2 −1

Original line number	Diff line number	Diff line
		@@ -91,10 +91,11 @@ public class PointerEventDispatcher extends InputEventReceiver {
		/** Dispose the associated input channel and clean up the listeners. */
		@Override
		public void dispose() {
		super.dispose();
		synchronized (mListeners) {
		mListeners.clear();
		mListenersArray = null;
		}
		// InputEventReceiver::dispose() must be called on the Looper thread.
		UiThread.getHandler().post(super::dispose);
		}
		}