Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 397afb54 authored by Andreas Huber's avatar Andreas Huber
Browse files

Fix a race condition in the prefetcher, the source may be shutdown while we're... 

Fix a race condition in the prefetcher, the source may be shutdown while we're reading data from it.

related-to-bug: 2453414
parent 5706329c

media/libstagefright/Prefetcher.cpp

+7 −11
Original line number Diff line number Diff line
@@ -337,7 +337,6 @@ bool PrefetchedSource::getCacheDurationUs(int64_t *durationUs) { 
void PrefetchedSource::cacheMore() {

    MediaSource::ReadOptions options;



    {

    Mutex::Autolock autoLock(mLock);



    if (!mStarted) {
@@ -348,13 +347,10 @@ void PrefetchedSource::cacheMore() { 
        options.setSeekTo(mSeekTimeUs);

        mSeekTimeUs = -1;

    }

    }



    MediaBuffer *buffer;

    status_t err = mSource->read(&buffer, &options);



    Mutex::Autolock autoLock(mLock);



    if (err != OK) {

        mReachedEOS = true;

        mCondition.signal();