Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3962c485 authored by Eric Laurent's avatar Eric Laurent
Browse files

AudioDeviceBroker: fix regression in isValidCommunicationDevice 

Commit 1dea0dab introduced a regression were the verification that the
device is a sink (output) device was removed from
isValidCommunicationDevice method.

Bug: 247659585
Bug: 266067856
Test: atest AudioCommunicationDeviceTest
Change-Id: Ie55debfeac1de21ef73c4de0f190cc77fa3b02be
parent c00165b1

services/core/java/com/android/server/audio/AudioDeviceBroker.java

+4 −2
Original line number Diff line number Diff line
@@ -68,6 +68,7 @@ import java.util.HashSet; 
import java.util.LinkedList;

import java.util.List;

import java.util.NoSuchElementException;

import java.util.Objects;

import java.util.Set;

import java.util.UUID;

import java.util.concurrent.atomic.AtomicBoolean;
@@ -496,8 +497,9 @@ public class AudioDeviceBroker { 
            AudioDeviceInfo.TYPE_AUX_LINE

    };



    /*package */ static boolean isValidCommunicationDevice(AudioDeviceInfo device) {

        return isValidCommunicationDeviceType(device.getType());

    /*package */ static boolean isValidCommunicationDevice(@NonNull AudioDeviceInfo device) {

        Objects.requireNonNull(device, "device must not be null");

        return device.isSink() && isValidCommunicationDeviceType(device.getType());

    }



    private static boolean isValidCommunicationDeviceType(int deviceType) {