Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3954fd9a authored by Raph Levien's avatar Raph Levien
Browse files

Revert "Take the input device into account for meta state" 

This reverts commit 8a1597b3. That
commit broke some of the handling of meta state, which in turn caused
CTS test failures, notably bug 10210151 (CTS:
android.text.method.cts.BaseKeyListenerTest#testBackspace_withSendKeys
is failing on KLP).

So this revert fixes those test failures, but leaves bug 8303489
(Pressing shift on the hardware keyboard messes with unrelated
keypresses, including virtual ones) still present. We'll plan to
address that in a future release.

Change-Id: Iea42c643b6d08f33cbd2ed1747e8de3b5f8116a6
parent 6b2b8459

api/current.txt

+0 −2
Original line number Diff line number Diff line
@@ -24925,9 +24925,7 @@ package android.text.method { 
    method public static void clearMetaKeyState(android.text.Editable, int);

    method public long clearMetaKeyState(long, int);

    method public static final int getMetaState(java.lang.CharSequence);

    method public static final int getMetaState(java.lang.CharSequence, android.view.KeyEvent);

    method public static final int getMetaState(java.lang.CharSequence, int);

    method public static final int getMetaState(java.lang.CharSequence, int, android.view.KeyEvent);

    method public static final int getMetaState(long);

    method public static final int getMetaState(long, int);

    method public static long handleKeyDown(long, int, android.view.KeyEvent);

core/java/android/text/method/ArrowKeyMovementMethod.java

+1 −1
Original line number Diff line number Diff line
@@ -56,7 +56,7 @@ public class ArrowKeyMovementMethod extends BaseMovementMethod implements Moveme 
                    if (event.getAction() == KeyEvent.ACTION_DOWN

                            && event.getRepeatCount() == 0

                            && MetaKeyKeyListener.getMetaState(buffer,

                                        MetaKeyKeyListener.META_SELECTING, event) != 0) {

                                        MetaKeyKeyListener.META_SELECTING) != 0) {

                        return widget.showContextMenu();

                    }

                }

core/java/android/text/method/BaseKeyListener.java

+1 −1
Original line number Diff line number Diff line
@@ -75,7 +75,7 @@ public abstract class BaseKeyListener extends MetaKeyKeyListener 
        }



        // Alt+Backspace or Alt+ForwardDelete deletes the current line, if possible.

        if (getMetaState(content, META_ALT_ON, event) == 1) {

        if (event.isAltPressed() || getMetaState(content, META_ALT_ON) == 1) {

            if (deleteLine(view, content)) {

                return true;

            }

core/java/android/text/method/BaseMovementMethod.java

+1 −1
Original line number Diff line number Diff line
@@ -135,7 +135,7 @@ public class BaseMovementMethod implements MovementMethod { 
     */

    protected int getMovementMetaState(Spannable buffer, KeyEvent event) {

        // We ignore locked modifiers and SHIFT.

        int metaState = MetaKeyKeyListener.getMetaState(buffer, event)

        int metaState = (event.getMetaState() | MetaKeyKeyListener.getMetaState(buffer))

                & ~(MetaKeyKeyListener.META_ALT_LOCKED | MetaKeyKeyListener.META_SYM_LOCKED);

        return KeyEvent.normalizeMetaState(metaState) & ~KeyEvent.META_SHIFT_MASK;

    }

core/java/android/text/method/DialerKeyListener.java

+1 −1
Original line number Diff line number Diff line
@@ -53,7 +53,7 @@ public class DialerKeyListener extends NumberKeyListener 
     * from the KeyEvent.

     */

    protected int lookup(KeyEvent event, Spannable content) {

        int meta = getMetaState(content, event);

        int meta = event.getMetaState() | getMetaState(content);

        int number = event.getNumber();



        /*