Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 391a1fc3 authored by Caitlin Shkuratov's avatar Caitlin Shkuratov
Browse files

[SB][Notif] If there's 2 chips, make both chips as compact as possible.

The new POR is that if we have 2 active chips, we prefer seeing both
chips as icon-only (or text-only) chips instead of seeing the first chip
with icon+text and having the second chip completely hidden.

Most chips will hide their text and become icon-only. The only exception
to this is the 3-2-1 screen record countdown chip, which always shows a
single digit without an icon and will continue to do that even when
there's 2 chips.

Caveats:
 - The icon-only squishing will only happen for phones in portrait; for
   all other configurations, there's enough room to show 2 full-sized
   chips.
 - We also need to re-implement this in the Compose chips. That'll
   happen in a separate CL.

Bug: 392895330
Bug: 364653005
Flag: com.android.systemui.status_bar_notification_chips
Test: Have 3-2-1 countdown chip + other chip -> verify see countdown
number & other chip with icon only
Test: Have 2 RON chips in portrait phone -> verify both are icon only
Test: Have call chip + RON chip in portrait phone -> verify both are icon only
Test: Have screen record chip + other chip in portrait phone -> verify both are icon only
Test: Have 2 chips then remove one in portrait phone -> verify first chip re-expands to
icon+text

Test: with status_bar_notification_chips OFF, have both a call and
screen record active -> verify screen record chip shows, and shows with
a timer (basically, verify squishing doesn't happen if we don't support
multiple chips)
Test: Have 2 RON chips in portrait phone then rotate -> verify chips
update to show text
Test: Have 2 RON chips on a large screen -> verify chips show text

Test: atest OngoingActivityChipsViewModelTest
Change-Id: I283d4c38b8d4f25e369fe6ab7d7fbf5a9017633c
parent ea55a5ff
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment