Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 38fa37df authored by Daniel's avatar Daniel Committed by Daniel Kim
Browse files

is_credential_request field for presentation metric 

Adding is_credential_request to the presentation stats metrics to
identify the request as either the autofill request or the credential
request

Bug: 317819515
Test: m (build)
Change-Id: I287a63a7c80727247a5f09fec8517c2190e7eef9
parent fe0fc871

services/autofill/java/com/android/server/autofill/PresentationStatsEventLogger.java

+15 −2
Original line number Diff line number Diff line
@@ -240,10 +240,20 @@ public final class PresentationStatsEventLogger { 
        mEventInternal = Optional.of(new PresentationStatsEventInternal());

    }



    /**

     * Set request_id

     */

    public void maybeSetRequestId(int requestId) {

        mEventInternal.ifPresent(event -> event.mRequestId = requestId);

    }



    /**

     * Set is_credential_request

     */

    public void maybeSetIsCredentialRequest(boolean isCredentialRequest) {

        mEventInternal.ifPresent(event -> event.mIsCredentialRequest = isCredentialRequest);

    }



    public void maybeSetNoPresentationEventReason(@NotShownReason int reason) {

        mEventInternal.ifPresent(event -> {

            if (event.mCountShown == 0) {
@@ -567,7 +577,8 @@ public final class PresentationStatsEventLogger { 
                    + " mSelectedDatasetPickedReason=" + event.mSelectedDatasetPickedReason

                    + " mDetectionPreference=" + event.mDetectionPreference

                    + " mFieldClassificationRequestId=" + event.mFieldClassificationRequestId

                    + " mAppPackageUid=" + mCallingAppUid);

                    + " mAppPackageUid=" + mCallingAppUid

                    + " mIsCredentialRequest=" + event.mIsCredentialRequest);

        }



        // TODO(b/234185326): Distinguish empty responses from other no presentation reasons.
@@ -606,7 +617,8 @@ public final class PresentationStatsEventLogger { 
                event.mSelectedDatasetPickedReason,

                event.mDetectionPreference,

                event.mFieldClassificationRequestId,

                mCallingAppUid);

                mCallingAppUid,

                event.mIsCredentialRequest);

        mEventInternal = Optional.empty();

    }
@@ -640,6 +652,7 @@ public final class PresentationStatsEventLogger { 
        @DatasetPickedReason int mSelectedDatasetPickedReason = PICK_REASON_UNKNOWN;

        @DetectionPreference int mDetectionPreference = DETECTION_PREFER_UNKNOWN;

        int mFieldClassificationRequestId = -1;

        boolean mIsCredentialRequest = false;



        PresentationStatsEventInternal() {}

    }