Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 38781bd2 authored by Svet Ganov's avatar Svet Ganov Committed by Svetoslav Ganov
Browse files

Fix some minor print UX bugs. 

1. The last row of print options was not visible on a phone.

2. The preview page size on a phone in landscape unusably small.

3. Updated the Save to PDF icon.

bug:16966145

Change-Id: I25ce1572758c62f34344683af2452fb045bb857e
parent 79dea425

packages/PrintSpooler/res/drawable/ic_savetopdf.xml

0 → 100644
+19 −0
Original line number Diff line number Diff line 
<?xml version="1.0" encoding="utf-8"?>

<!-- Copyright (C) 2014 The Android Open Source Project



     Licensed under the Apache License, Version 2.0 (the "License");

     you may not use this file except in compliance with the License.

     You may obtain a copy of the License at



          http://www.apache.org/licenses/LICENSE-2.0



     Unless required by applicable law or agreed to in writing, software

     distributed under the License is distributed on an "AS IS" BASIS,

     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

     See the License for the specific language governing permissions and

     limitations under the License.

-->



<bitmap xmlns:android="http://schemas.android.com/apk/res/android"

    android:src="@drawable/ic_menu_savetopdf"

    android:tint="@color/promoted_action_background_color" />

packages/PrintSpooler/res/layout/preview_page.xml

+1 −1
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ 
    <RelativeLayout

        android:id="@+id/page_footer"

        android:layout_width="fill_parent"

        android:layout_height="32dip"

        android:layout_height="@dimen/preview_page_footer_height"

        android:background="@*android:color/material_grey_500"

        android:orientation="horizontal">

packages/PrintSpooler/res/layout/print_activity.xml

+1 −5
Original line number Diff line number Diff line
@@ -27,7 +27,6 @@ 
        android:id="@+id/static_content"

        android:layout_width="fill_parent"

        android:layout_height="wrap_content"

        android:padding="16dip"

        android:elevation="@dimen/preview_controls_elevation"

        android:background="?android:attr/colorPrimary">
@@ -35,6 +34,7 @@ 
            android:id="@+id/destination_spinner"

            android:layout_width="wrap_content"

            android:layout_height="wrap_content"

            android:layout_marginTop="4dip"

            android:dropDownWidth="wrap_content"

            android:minHeight="?android:attr/listPreferredItemHeightSmall">

        </Spinner>
@@ -56,7 +56,6 @@ 
        <TextView

            android:layout_width="wrap_content"

            android:layout_height="wrap_content"

            android:layout_marginTop="8dip"

            android:layout_marginStart="12dip"

            android:textAppearance="?android:attr/textAppearanceSmall"

            android:labelFor="@+id/copies_count_summary"
@@ -67,7 +66,6 @@ 
            android:id="@+id/copies_count_summary"

            android:layout_width="wrap_content"

            android:layout_height="wrap_content"

            android:layout_marginTop="8dip"

            android:layout_marginStart="16dip"

            android:textAppearance="?android:attr/textAppearanceMedium"

            android:textColor="?android:attr/textColorPrimary">
@@ -76,7 +74,6 @@ 
        <TextView

            android:layout_width="wrap_content"

            android:layout_height="wrap_content"

            android:layout_marginTop="8dip"

            android:layout_marginStart="32dip"

            android:textAppearance="?android:attr/textAppearanceSmall"

            android:labelFor="@+id/paper_size_summary"
@@ -87,7 +84,6 @@ 
            android:id="@+id/paper_size_summary"

            android:layout_width="wrap_content"

            android:layout_height="wrap_content"

            android:layout_marginTop="8dip"

            android:layout_marginStart="16dip"

            android:textAppearance="?android:attr/textAppearanceMedium"

            android:textColor="?android:attr/textColorPrimary">

packages/PrintSpooler/res/layout/print_activity_controls.xml

+2 −2
Original line number Diff line number Diff line
@@ -267,8 +267,8 @@ 
             android:id="@+id/expand_collapse_icon"

             android:layout_width="wrap_content"

             android:layout_height="wrap_content"

             android:layout_marginTop="8dip"

             android:layout_marginBottom="8dip"

             android:layout_marginTop="4dip"

             android:layout_marginBottom="4dip"

             android:layout_gravity="center"

             android:background="@drawable/ic_expand_more">

         </ImageView>

packages/PrintSpooler/res/values/constants.xml

+3 −0
Original line number Diff line number Diff line
@@ -45,4 +45,7 @@ 
    <fraction name="page_selected_alpha">100%</fraction>

    <fraction name="page_unselected_alpha">50%</fraction>



    <dimen name="preview_page_footer_height">32dip</dimen>

    <dimen name="preview_page_min_width">130dip</dimen>



</resources>