Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3864a348 authored by Joe Onorato's avatar Joe Onorato
Browse files

Fix lookup of incident section by name to not crash. 

Bug: 132890298
Test: adb shell incident asdfadfasdfadf doesn't crash
Change-Id: I74226960e8e2643df3491cd9dff8e9acc639e24f
parent 5dfe3dfe

cmds/incident/main.cpp

+4 −3
Original line number Diff line number Diff line
@@ -133,11 +133,11 @@ static void section_list(FILE* out) { 
static IncidentSection const*

find_section(const char* name)

{

    size_t low = 0;

    size_t high = INCIDENT_SECTION_COUNT - 1;

    ssize_t low = 0;

    ssize_t high = INCIDENT_SECTION_COUNT - 1;



    while (low <= high) {

        size_t mid = (low + high) >> 1;

        ssize_t mid = (low + high) / 2;

        IncidentSection const* section = INCIDENT_SECTIONS + mid;



        int cmp = strcmp(section->name, name);
@@ -304,6 +304,7 @@ main(int argc, char** argv) 
                } else {

                    IncidentSection const* ic = find_section(arg);

                    if (ic == NULL) {

                        ALOGD("Invalid section: %s\n", arg);

                        fprintf(stderr, "Invalid section: %s\n", arg);

                        return 1;

                    }