Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3858b2d1 authored by Kweku Adams's avatar Kweku Adams
Browse files

Add extra comment for implementation. 

Add a comment noting that the check to throw the exception is
intentionally second so that it's out of the critical path.

Bug: 118339123
Test: N/A
Change-Id: I36c5ea67579bcd7906f711530392110d9987ffb4
parent ebc87475

core/java/android/util/ArrayMap.java

+4 −0
Original line number Diff line number Diff line
@@ -461,6 +461,7 @@ public final class ArrayMap<K, V> implements Map<K, V> { 
    public K keyAt(int index) {

        if (index >= mSize && UtilConfig.sThrowExceptionForUpperArrayOutOfBounds) {

            // The array might be slightly bigger than mSize, in which case, indexing won't fail.

            // Check if exception should be thrown outside of the critical path.

            throw new ArrayIndexOutOfBoundsException(index);

        }

        return (K)mArray[index << 1];
@@ -480,6 +481,7 @@ public final class ArrayMap<K, V> implements Map<K, V> { 
    public V valueAt(int index) {

        if (index >= mSize && UtilConfig.sThrowExceptionForUpperArrayOutOfBounds) {

            // The array might be slightly bigger than mSize, in which case, indexing won't fail.

            // Check if exception should be thrown outside of the critical path.

            throw new ArrayIndexOutOfBoundsException(index);

        }

        return (V)mArray[(index << 1) + 1];
@@ -500,6 +502,7 @@ public final class ArrayMap<K, V> implements Map<K, V> { 
    public V setValueAt(int index, V value) {

        if (index >= mSize && UtilConfig.sThrowExceptionForUpperArrayOutOfBounds) {

            // The array might be slightly bigger than mSize, in which case, indexing won't fail.

            // Check if exception should be thrown outside of the critical path.

            throw new ArrayIndexOutOfBoundsException(index);

        }

        index = (index << 1) + 1;
@@ -703,6 +706,7 @@ public final class ArrayMap<K, V> implements Map<K, V> { 
    public V removeAt(int index) {

        if (index >= mSize && UtilConfig.sThrowExceptionForUpperArrayOutOfBounds) {

            // The array might be slightly bigger than mSize, in which case, indexing won't fail.

            // Check if exception should be thrown outside of the critical path.

            throw new ArrayIndexOutOfBoundsException(index);

        }

core/java/android/util/ArraySet.java

+2 −0
Original line number Diff line number Diff line
@@ -368,6 +368,7 @@ public final class ArraySet<E> implements Collection<E>, Set<E> { 
    public E valueAt(int index) {

        if (index >= mSize && UtilConfig.sThrowExceptionForUpperArrayOutOfBounds) {

            // The array might be slightly bigger than mSize, in which case, indexing won't fail.

            // Check if exception should be thrown outside of the critical path.

            throw new ArrayIndexOutOfBoundsException(index);

        }

        return valueAtUnchecked(index);
@@ -545,6 +546,7 @@ public final class ArraySet<E> implements Collection<E>, Set<E> { 
    public E removeAt(int index) {

        if (index >= mSize && UtilConfig.sThrowExceptionForUpperArrayOutOfBounds) {

            // The array might be slightly bigger than mSize, in which case, indexing won't fail.

            // Check if exception should be thrown outside of the critical path.

            throw new ArrayIndexOutOfBoundsException(index);

        }

        final Object old = mArray[index];

core/java/android/util/LongSparseArray.java

+4 −0
Original line number Diff line number Diff line
@@ -151,6 +151,7 @@ public class LongSparseArray<E> implements Cloneable { 
    public void removeAt(int index) {

        if (index >= mSize && UtilConfig.sThrowExceptionForUpperArrayOutOfBounds) {

            // The array might be slightly bigger than mSize, in which case, indexing won't fail.

            // Check if exception should be thrown outside of the critical path.

            throw new ArrayIndexOutOfBoundsException(index);

        }

        if (mValues[index] != DELETED) {
@@ -249,6 +250,7 @@ public class LongSparseArray<E> implements Cloneable { 
    public long keyAt(int index) {

        if (index >= mSize && UtilConfig.sThrowExceptionForUpperArrayOutOfBounds) {

            // The array might be slightly bigger than mSize, in which case, indexing won't fail.

            // Check if exception should be thrown outside of the critical path.

            throw new ArrayIndexOutOfBoundsException(index);

        }

        if (mGarbage) {
@@ -278,6 +280,7 @@ public class LongSparseArray<E> implements Cloneable { 
    public E valueAt(int index) {

        if (index >= mSize && UtilConfig.sThrowExceptionForUpperArrayOutOfBounds) {

            // The array might be slightly bigger than mSize, in which case, indexing won't fail.

            // Check if exception should be thrown outside of the critical path.

            throw new ArrayIndexOutOfBoundsException(index);

        }

        if (mGarbage) {
@@ -300,6 +303,7 @@ public class LongSparseArray<E> implements Cloneable { 
    public void setValueAt(int index, E value) {

        if (index >= mSize && UtilConfig.sThrowExceptionForUpperArrayOutOfBounds) {

            // The array might be slightly bigger than mSize, in which case, indexing won't fail.

            // Check if exception should be thrown outside of the critical path.

            throw new ArrayIndexOutOfBoundsException(index);

        }

        if (mGarbage) {

core/java/android/util/LongSparseLongArray.java

+2 −0
Original line number Diff line number Diff line
@@ -179,6 +179,7 @@ public class LongSparseLongArray implements Cloneable { 
    public long keyAt(int index) {

        if (index >= mSize && UtilConfig.sThrowExceptionForUpperArrayOutOfBounds) {

            // The array might be slightly bigger than mSize, in which case, indexing won't fail.

            // Check if exception should be thrown outside of the critical path.

            throw new ArrayIndexOutOfBoundsException(index);

        }

        return mKeys[index];
@@ -203,6 +204,7 @@ public class LongSparseLongArray implements Cloneable { 
    public long valueAt(int index) {

        if (index >= mSize && UtilConfig.sThrowExceptionForUpperArrayOutOfBounds) {

            // The array might be slightly bigger than mSize, in which case, indexing won't fail.

            // Check if exception should be thrown outside of the critical path.

            throw new ArrayIndexOutOfBoundsException(index);

        }

        return mValues[index];

core/java/android/util/SparseArray.java

+4 −0
Original line number Diff line number Diff line
@@ -176,6 +176,7 @@ public class SparseArray<E> implements Cloneable { 
    public void removeAt(int index) {

        if (index >= mSize && UtilConfig.sThrowExceptionForUpperArrayOutOfBounds) {

            // The array might be slightly bigger than mSize, in which case, indexing won't fail.

            // Check if exception should be thrown outside of the critical path.

            throw new ArrayIndexOutOfBoundsException(index);

        }

        if (mValues[index] != DELETED) {
@@ -290,6 +291,7 @@ public class SparseArray<E> implements Cloneable { 
    public int keyAt(int index) {

        if (index >= mSize && UtilConfig.sThrowExceptionForUpperArrayOutOfBounds) {

            // The array might be slightly bigger than mSize, in which case, indexing won't fail.

            // Check if exception should be thrown outside of the critical path.

            throw new ArrayIndexOutOfBoundsException(index);

        }

        if (mGarbage) {
@@ -319,6 +321,7 @@ public class SparseArray<E> implements Cloneable { 
    public E valueAt(int index) {

        if (index >= mSize && UtilConfig.sThrowExceptionForUpperArrayOutOfBounds) {

            // The array might be slightly bigger than mSize, in which case, indexing won't fail.

            // Check if exception should be thrown outside of the critical path.

            throw new ArrayIndexOutOfBoundsException(index);

        }

        if (mGarbage) {
@@ -341,6 +344,7 @@ public class SparseArray<E> implements Cloneable { 
    public void setValueAt(int index, E value) {

        if (index >= mSize && UtilConfig.sThrowExceptionForUpperArrayOutOfBounds) {

            // The array might be slightly bigger than mSize, in which case, indexing won't fail.

            // Check if exception should be thrown outside of the critical path.

            throw new ArrayIndexOutOfBoundsException(index);

        }

        if (mGarbage) {