Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 384db3f4 authored by Philip P. Moltmann's avatar Philip P. Moltmann
Browse files

Log path on priv permission failure 

It is a frequent issue that a developer installs a package without
updating the privapp permission whitelist. Add additional logging to
point the developer to the offending package.

Fixes: 137080687
Test: Added non-whitelisted permission to package to trigger this log
Change-Id: Ib40ee452cd214dbd74dbe11b4b2d269855a72a2c
parent 42301182

services/core/java/com/android/server/pm/permission/PermissionManagerService.java

+4 −2
Original line number Diff line number Diff line
@@ -1721,13 +1721,15 @@ public class PermissionManagerService extends IPermissionManager.Stub { 
                            deniedPermissions == null || !deniedPermissions.contains(perm);

                    if (permissionViolation) {

                        Slog.w(TAG, "Privileged permission " + perm + " for package "

                                + pkg.packageName + " - not in privapp-permissions whitelist");

                                + pkg.packageName + " (" + pkg.codePath

                                + ") not in privapp-permissions whitelist");



                        if (RoSystemProperties.CONTROL_PRIVAPP_PERMISSIONS_ENFORCE) {

                            if (mPrivappPermissionsViolations == null) {

                                mPrivappPermissionsViolations = new ArraySet<>();

                            }

                            mPrivappPermissionsViolations.add(pkg.packageName + ": " + perm);

                            mPrivappPermissionsViolations.add(

                                    pkg.packageName + " (" + pkg.codePath + "): " + perm);

                        }

                    } else {

                        return false;