Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 381ba3e2 authored by David Su's avatar David Su
Browse files

Wifi: Rename requirePMF to requirePmf 

Rename to conform to API guidelines.

Bug: 146046526
Test: compiles
Change-Id: If8089bcbf9e18d4fadfe8abe7fdab418f8c1bbca
parent 004e36da

api/system-current.txt

+1 −1
Original line number Diff line number Diff line
@@ -7588,7 +7588,7 @@ package android.net.wifi { 
    field @Deprecated public int numAssociation;

    field @Deprecated public int numScorerOverride;

    field @Deprecated public int numScorerOverrideAndSwitchedNetwork;

    field @Deprecated public boolean requirePMF;

    field @Deprecated public boolean requirePmf;

    field @Deprecated @Nullable public String saePasswordId;

    field @Deprecated public boolean shared;

    field @Deprecated public boolean useExternalScores;

api/system-lint-baseline.txt

+1 −1
Original line number Diff line number Diff line
@@ -206,7 +206,7 @@ MutableBareField: android.net.wifi.WifiConfiguration#macRandomizationSetting: 
    

MutableBareField: android.net.wifi.WifiConfiguration#meteredOverride:

    

MutableBareField: android.net.wifi.WifiConfiguration#requirePMF:

MutableBareField: android.net.wifi.WifiConfiguration#requirePmf:

    

MutableBareField: android.net.wifi.WifiConfiguration#saePasswordId:

wifi/java/android/net/wifi/WifiConfiguration.java

+8 −8
Original line number Diff line number Diff line
@@ -486,7 +486,7 @@ public class WifiConfiguration implements Parcelable { 
                allowedKeyManagement.set(WifiConfiguration.KeyMgmt.SAE);

                allowedPairwiseCiphers.set(WifiConfiguration.PairwiseCipher.CCMP);

                allowedGroupCiphers.set(WifiConfiguration.GroupCipher.CCMP);

                requirePMF = true;

                requirePmf = true;

                break;

            case SECURITY_TYPE_EAP_SUITE_B:

                allowedProtocols.set(WifiConfiguration.Protocol.RSN);
@@ -496,14 +496,14 @@ public class WifiConfiguration implements Parcelable { 
                allowedGroupManagementCiphers.set(WifiConfiguration.GroupMgmtCipher.BIP_GMAC_256);

                // Note: allowedSuiteBCiphers bitset will be set by the service once the

                // certificates are attached to this profile

                requirePMF = true;

                requirePmf = true;

                break;

            case SECURITY_TYPE_OWE:

                allowedProtocols.set(WifiConfiguration.Protocol.RSN);

                allowedKeyManagement.set(WifiConfiguration.KeyMgmt.OWE);

                allowedPairwiseCiphers.set(WifiConfiguration.PairwiseCipher.CCMP);

                allowedGroupCiphers.set(WifiConfiguration.GroupCipher.CCMP);

                requirePMF = true;

                requirePmf = true;

                break;

            case SECURITY_TYPE_WAPI_PSK:

                allowedKeyManagement.set(WifiConfiguration.KeyMgmt.WAPI_PSK);
@@ -662,7 +662,7 @@ public class WifiConfiguration implements Parcelable { 
     * @hide

     */

    @SystemApi

    public boolean requirePMF;

    public boolean requirePmf;



    /**

     * Update identifier, for Passpoint network.
@@ -2168,7 +2168,7 @@ public class WifiConfiguration implements Parcelable { 
                append(" BSSID: ").append(this.BSSID).append(" FQDN: ").append(this.FQDN)

                .append(" PRIO: ").append(this.priority)

                .append(" HIDDEN: ").append(this.hiddenSSID)

                .append(" PMF: ").append(this.requirePMF)

                .append(" PMF: ").append(this.requirePmf)

                .append("CarrierId: ").append(this.carrierId)

                .append('\n');
@@ -2757,7 +2757,7 @@ public class WifiConfiguration implements Parcelable { 
            mRandomizedMacAddress = source.mRandomizedMacAddress;

            macRandomizationSetting = source.macRandomizationSetting;

            randomizedMacExpirationTimeMs = source.randomizedMacExpirationTimeMs;

            requirePMF = source.requirePMF;

            requirePmf = source.requirePmf;

            updateIdentifier = source.updateIdentifier;

            carrierId = source.carrierId;

            mPasspointUniqueId = source.mPasspointUniqueId;
@@ -2789,7 +2789,7 @@ public class WifiConfiguration implements Parcelable { 
        dest.writeInt(wepTxKeyIndex);

        dest.writeInt(priority);

        dest.writeInt(hiddenSSID ? 1 : 0);

        dest.writeInt(requirePMF ? 1 : 0);

        dest.writeInt(requirePmf ? 1 : 0);

        dest.writeString(updateIdentifier);



        writeBitSet(dest, allowedKeyManagement);
@@ -2865,7 +2865,7 @@ public class WifiConfiguration implements Parcelable { 
                config.wepTxKeyIndex = in.readInt();

                config.priority = in.readInt();

                config.hiddenSSID = in.readInt() != 0;

                config.requirePMF = in.readInt() != 0;

                config.requirePmf = in.readInt() != 0;

                config.updateIdentifier = in.readString();



                config.allowedKeyManagement   = readBitSet(in);

wifi/tests/src/android/net/wifi/WifiConfigurationTest.java

+3 −3
Original line number Diff line number Diff line
@@ -363,7 +363,7 @@ public class WifiConfigurationTest { 
        assertTrue(config.allowedKeyManagement.get(WifiConfiguration.KeyMgmt.SAE));

        assertTrue(config.allowedPairwiseCiphers.get(WifiConfiguration.PairwiseCipher.CCMP));

        assertTrue(config.allowedGroupCiphers.get(WifiConfiguration.GroupCipher.CCMP));

        assertTrue(config.requirePMF);

        assertTrue(config.requirePmf);

    }



    /**
@@ -380,7 +380,7 @@ public class WifiConfigurationTest { 
        assertTrue(config.allowedKeyManagement.get(WifiConfiguration.KeyMgmt.OWE));

        assertTrue(config.allowedPairwiseCiphers.get(WifiConfiguration.PairwiseCipher.CCMP));

        assertTrue(config.allowedGroupCiphers.get(WifiConfiguration.GroupCipher.CCMP));

        assertTrue(config.requirePMF);

        assertTrue(config.requirePmf);

    }



    /**
@@ -399,7 +399,7 @@ public class WifiConfigurationTest { 
        assertTrue(config.allowedGroupCiphers.get(WifiConfiguration.GroupCipher.GCMP_256));

        assertTrue(config.allowedGroupManagementCiphers

                .get(WifiConfiguration.GroupMgmtCipher.BIP_GMAC_256));

        assertTrue(config.requirePMF);

        assertTrue(config.requirePmf);

    }



    /**

wifi/tests/src/android/net/wifi/WifiNetworkSuggestionTest.java

+3 −3
Original line number Diff line number Diff line
@@ -140,7 +140,7 @@ public class WifiNetworkSuggestionTest { 
        assertTrue(suggestion.wifiConfiguration.allowedKeyManagement

                .get(WifiConfiguration.KeyMgmt.OWE));

        assertNull(suggestion.wifiConfiguration.preSharedKey);

        assertTrue(suggestion.wifiConfiguration.requirePMF);

        assertTrue(suggestion.wifiConfiguration.requirePmf);

        assertFalse(suggestion.isUserAllowedToManuallyConnect);

        assertTrue(suggestion.isInitialAutoJoinEnabled);

    }
@@ -163,7 +163,7 @@ public class WifiNetworkSuggestionTest { 
                .get(WifiConfiguration.KeyMgmt.SAE));

        assertEquals("\"" + TEST_PRESHARED_KEY + "\"",

                suggestion.wifiConfiguration.preSharedKey);

        assertTrue(suggestion.wifiConfiguration.requirePMF);

        assertTrue(suggestion.wifiConfiguration.requirePmf);

        assertTrue(suggestion.isUserAllowedToManuallyConnect);

        assertFalse(suggestion.isInitialAutoJoinEnabled);

    }
@@ -191,7 +191,7 @@ public class WifiNetworkSuggestionTest { 
                .get(WifiConfiguration.GroupCipher.GCMP_256));

        assertTrue(suggestion.wifiConfiguration.allowedGroupManagementCiphers

                .get(WifiConfiguration.GroupMgmtCipher.BIP_GMAC_256));

        assertTrue(suggestion.wifiConfiguration.requirePMF);

        assertTrue(suggestion.wifiConfiguration.requirePmf);

        assertNull(suggestion.wifiConfiguration.preSharedKey);

        // allowedSuiteBCiphers are set according to the loaded certificate and cannot be tested

        // here.