Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 37d2cc11 authored by Matías Hernández's avatar Matías Hernández
Browse files

Improve delete-intent-from-cached-summary tests 

They can check the actual expectation now that GroupHelper is no longer a mock.

Bug: 358074581
Test: atest NotificationManagerServiceTest
Flag: TEST_ONLY
Change-Id: Iea329f7d3762c2f4001ff609754d9458bf1dbb76
parent 0e8f3fd3

services/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java

+8 −4
Original line number Diff line number Diff line
@@ -20566,9 +20566,11 @@ public class NotificationManagerServiceTest extends UiServiceTestCase { 














    @Test















    @EnableFlags(FLAG_NOTIFICATION_FORCE_GROUPING)













    public void clearAll_fromUser_willSendDeleteIntentForCachedSummaries() throws Exception {













    public void clearAll_fromUser_sendsDeleteIntentForCachedSummaries() throws Exception {













        PendingIntent deleteIntent = mock(PendingIntent.class);















        NotificationRecord n = generateNotificationRecord(















                mTestNotificationChannel, 1, "group", true);













        n.getNotification().deleteIntent = deleteIntent;















        mBinderService.enqueueNotificationWithTag(mPkg, mPkg, "tag",















                n.getSbn().getId(), n.getSbn().getNotification(), n.getSbn().getUserId());















        waitForIdle();









@@ -20577,14 +20579,16 @@ public class NotificationManagerServiceTest extends UiServiceTestCase {













        mService.mNotificationDelegate.onClearAll(mUid, Binder.getCallingPid(), n.getUserId());















        waitForIdle();



























        verify(mGroupHelper).onNotificationRemoved(eq(n), any(), eq(true));













        verify(deleteIntent).send();















    }





























    @Test















    @EnableFlags(FLAG_NOTIFICATION_FORCE_GROUPING)













    public void cancel_fromApp_willNotSendDeleteIntentForCachedSummaries() throws Exception {













    public void cancel_fromApp_doesNotSendDeleteIntentForCachedSummaries() throws Exception {













        PendingIntent deleteIntent = mock(PendingIntent.class);















        NotificationRecord n = generateNotificationRecord(















                mTestNotificationChannel, 1, "group", true);













        n.getNotification().deleteIntent = deleteIntent;















        mBinderService.enqueueNotificationWithTag(mPkg, mPkg, "tag",















                n.getSbn().getId(), n.getSbn().getNotification(), n.getSbn().getUserId());















        waitForIdle();









@@ -20593,7 +20597,7 @@ public class NotificationManagerServiceTest extends UiServiceTestCase {













        mBinderService.cancelAllNotifications(mPkg, mUserId);















        waitForIdle();



























        verify(mGroupHelper).onNotificationRemoved(eq(n), any(), eq(false));













        verify(deleteIntent, never()).send();















    }





























    @Test