Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 37b214b8 authored by Chandru S's avatar Chandru S
Browse files

Do not make device is asleep a gating condition for face auth 

This prevents face auth from running when the user touches the UDFPS sensor on AOD
The device would still be asleep but we still want to run face auth.

This also fixes race conditions between device asleep still being true when we trigger face auth by lifting the device or tapping the device to wake up.

Fixes: 285499709
Fixes: 285501230

Test: atest DeviceEntryFaceAuthRepositoryTest
Change-Id: Ieaef83a2695de1c2d369068b4db08df5acb2357d
parent b6629a26

packages/SystemUI/src/com/android/systemui/keyguard/data/repository/DeviceEntryFaceAuthRepository.kt

+2 −2
Original line number Diff line number Diff line
@@ -312,8 +312,8 @@ constructor( 
                    tableLogBuffer

                ),

                logAndObserve(

                    keyguardRepository.wakefulness.map { it.isStartingToSleepOrAsleep() }.isFalse(),

                    "deviceNotSleepingOrNotStartingToSleep",

                    keyguardRepository.wakefulness.map { it.isStartingToSleep() }.isFalse(),

                    "deviceNotStartingToSleep",

                    tableLogBuffer

                ),

                logAndObserve(

packages/SystemUI/tests/src/com/android/systemui/keyguard/data/repository/DeviceEntryFaceAuthRepositoryTest.kt

+0 −14
Original line number Diff line number Diff line
@@ -550,20 +550,6 @@ class DeviceEntryFaceAuthRepositoryTest : SysuiTestCase() { 
            }

        }



    @Test

    fun authenticateDoesNotRunWhenDeviceIsSleeping() =

        testScope.runTest {

            testGatingCheckForFaceAuth {

                keyguardRepository.setWakefulnessModel(

                    WakefulnessModel(

                        state = WakefulnessState.ASLEEP,

                        lastWakeReason = WakeSleepReason.OTHER,

                        lastSleepReason = WakeSleepReason.OTHER,

                    )

                )

            }

        }



    @Test

    fun authenticateDoesNotRunWhenNonStrongBiometricIsNotAllowed() =

        testScope.runTest {