Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 379b4805 authored by Josh Yang's avatar Josh Yang
Browse files

Always trigger assistant gesture on STEM_PRIMARY long press. 

Flag: EXEMPTED minor bug fix
Bug: 355639036
Test: manual test in physical UX test app
Test: atest StemKeyGestureTests
Change-Id: Id19a2066dc2501a636ecd225645c4c0e54b0a368
parent a2246e9c

services/core/java/com/android/server/policy/PhoneWindowManager.java

+10 −5
Original line number Diff line number Diff line
@@ -2722,12 +2722,17 @@ public class PhoneWindowManager implements WindowManagerPolicy { 


        @Override

        void onLongPress(long eventTime) {

            // Long-press should be triggered only if app doesn't handle it.

            if (mLongPressOnStemPrimaryBehavior == LONG_PRESS_PRIMARY_LAUNCH_VOICE_ASSISTANT) {

                // Long-press to assistant gesture is not overridable by apps.

                stemPrimaryLongPress(eventTime);

            } else {

                // Other long-press actions should be triggered only if app doesn't handle it.

                mDeferredKeyActionExecutor.queueKeyAction(

                        KeyEvent.KEYCODE_STEM_PRIMARY,

                        eventTime,

                        () -> stemPrimaryLongPress(eventTime));

            }

        }



        @Override

        void onMultiPress(long downTime, int count, int unusedDisplayId) {

services/tests/wmtests/src/com/android/server/policy/StemKeyGestureTests.java

+20 −0
Original line number Diff line number Diff line
@@ -185,6 +185,26 @@ public class StemKeyGestureTests extends ShortcutKeyTestBase { 
        mPhoneWindowManager.assertStatusBarStartAssist();

    }



    @Test

    public void stemLongKey_appHasOverridePermission_consumedByApp_triggerStatusBarToStartAssist() {

        overrideBehavior(

                STEM_PRIMARY_BUTTON_LONG_PRESS,

                LONG_PRESS_PRIMARY_LAUNCH_VOICE_ASSISTANT);

        setUpPhoneWindowManager(/* supportSettingsUpdate= */ true);

        mPhoneWindowManager.overrideShouldEarlyShortPressOnStemPrimary(false);

        mPhoneWindowManager.setupAssistForLaunch();

        mPhoneWindowManager.overrideSearchManager(null);

        mPhoneWindowManager.overrideStatusBarManagerInternal();

        mPhoneWindowManager.overrideIsUserSetupComplete(true);

        mPhoneWindowManager.overrideFocusedWindowButtonOverridePermission(true);



        setDispatchedKeyHandler(keyEvent -> true);



        sendKey(KEYCODE_STEM_PRIMARY, /* longPress= */ true);



        mPhoneWindowManager.assertStatusBarStartAssist();

    }



    @Test

    public void stemDoubleKey_EarlyShortPress_AllAppsThenSwitchToMostRecent()

            throws RemoteException {