Remove SideStage class (3766ac54) · Commits · e / os / android_frameworks_base

libs/WindowManager/Shell/src/com/android/wm/shell/splitscreen/MainStage.java

+1 −1

Original line number	Diff line number	Diff line
		@@ -33,7 +33,7 @@ import java.util.Optional;

		/**
		* Main stage for split-screen mode. When split-screen is active all standard activity types launch
		* on the main stage, except for task that are explicitly pinned to the {@link SideStage}.
		* on the main stage, except for task that are explicitly pinned to the {@link StageTaskListener}.
		* @see StageCoordinator
		*/
		class MainStage extends StageTaskListener {

libs/WindowManager/Shell/src/com/android/wm/shell/splitscreen/SideStage.java

deleted100644 → 0

+0 −73

Original line number	Diff line number	Diff line
		/*
		* Copyright (C) 2020 The Android Open Source Project
		*
		* Licensed under the Apache License, Version 2.0 (the "License");
		* you may not use this file except in compliance with the License.
		* You may obtain a copy of the License at
		*
		* http://www.apache.org/licenses/LICENSE-2.0
		*
		* Unless required by applicable law or agreed to in writing, software
		* distributed under the License is distributed on an "AS IS" BASIS,
		* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
		* See the License for the specific language governing permissions and
		* limitations under the License.
		*/

		package com.android.wm.shell.splitscreen;

		import static com.android.wm.shell.protolog.ShellProtoLogGroup.WM_SHELL_SPLIT_SCREEN;

		import android.app.ActivityManager;
		import android.content.Context;
		import android.view.SurfaceSession;
		import android.window.WindowContainerToken;
		import android.window.WindowContainerTransaction;

		import com.android.internal.protolog.ProtoLog;
		import com.android.launcher3.icons.IconProvider;
		import com.android.wm.shell.ShellTaskOrganizer;
		import com.android.wm.shell.common.SyncTransactionQueue;
		import com.android.wm.shell.windowdecor.WindowDecorViewModel;

		import java.util.Optional;

		/**
		* Side stage for split-screen mode. Only tasks that are explicitly pinned to this stage show up
		* here. All other task are launch in the {@link MainStage}.
		*
		* @see StageCoordinator
		*/
		class SideStage extends StageTaskListener {
		private static final String TAG = SideStage.class.getSimpleName();

		SideStage(Context context, ShellTaskOrganizer taskOrganizer, int displayId,
		StageListenerCallbacks callbacks, SyncTransactionQueue syncQueue,
		SurfaceSession surfaceSession, IconProvider iconProvider,
		Optional<WindowDecorViewModel> windowDecorViewModel) {
		super(context, taskOrganizer, displayId, callbacks, syncQueue, surfaceSession,
		iconProvider, windowDecorViewModel);
		}

		boolean removeAllTasks(WindowContainerTransaction wct, boolean toTop) {
		ProtoLog.d(WM_SHELL_SPLIT_SCREEN, "remove all side stage tasks: childCount=%d toTop=%b",
		mChildrenTaskInfo.size(), toTop);
		if (mChildrenTaskInfo.size() == 0) return false;
		wct.reparentTasks(
		mRootTaskInfo.token,
		null /* newParent */,
		null /* windowingModes */,
		null /* activityTypes */,
		toTop);
		return true;
		}

		boolean removeTask(int taskId, WindowContainerToken newParent, WindowContainerTransaction wct) {
		final ActivityManager.RunningTaskInfo task = mChildrenTaskInfo.get(taskId);
		ProtoLog.d(WM_SHELL_SPLIT_SCREEN, "remove side stage task: task=%d exists=%b", taskId,
		task != null);
		if (task == null) return false;
		wct.reparent(task.token, newParent, false /* onTop */);
		return true;
		}
		}

libs/WindowManager/Shell/src/com/android/wm/shell/splitscreen/SplitScreen.java

+1 −1

Original line number	Diff line number	Diff line
		@@ -50,7 +50,7 @@ public interface SplitScreen {

		/**
		* The side stage type.
		* @see SideStage
		* @see StageTaskListener
		*/
		int STAGE_TYPE_SIDE = 1;

libs/WindowManager/Shell/src/com/android/wm/shell/splitscreen/StageCoordinator.java

+7 −7

Original line number	Diff line number	Diff line
		@@ -155,13 +155,13 @@ import java.util.concurrent.Executor;

		/**
		* Coordinates the staging (visibility, sizing, ...) of the split-screen {@link MainStage} and
		* {@link SideStage} stages.
		* other stages.
		* Some high-level rules:
		* - The {@link StageCoordinator} is only considered active if the {@link SideStage} contains at
		* - The {@link StageCoordinator} is only considered active if the other stages contain at
		* least one child task.
		* - The {@link MainStage} should only have children if the coordinator is active.
		* - The {@link SplitLayout} divider is only visible if both the {@link MainStage}
		* and {@link SideStage} are visible.
		* and other stages are visible.
		* - Both stages are put under a single-top root task.
		* This rules are mostly implemented in {@link #onStageVisibilityChanged(StageListenerImpl)} and
		* {@link #onStageHasChildrenChanged(StageListenerImpl).}
		@@ -176,7 +176,7 @@ public class StageCoordinator implements SplitLayout.SplitLayoutHandler,

		private final MainStage mMainStage;
		private final StageListenerImpl mMainStageListener = new StageListenerImpl();
		private final SideStage mSideStage;
		private final StageTaskListener mSideStage;
		private final StageListenerImpl mSideStageListener = new StageListenerImpl();
		@SplitPosition
		private int mSideStagePosition = SPLIT_POSITION_BOTTOM_OR_RIGHT;
		@@ -338,7 +338,7 @@ public class StageCoordinator implements SplitLayout.SplitLayoutHandler,
		mSurfaceSession,
		iconProvider,
		mWindowDecorViewModel);
		mSideStage = new SideStage(
		mSideStage = new StageTaskListener(
		mContext,
		mTaskOrganizer,
		mDisplayId,
		@@ -367,7 +367,7 @@ public class StageCoordinator implements SplitLayout.SplitLayoutHandler,

		@VisibleForTesting
		StageCoordinator(Context context, int displayId, SyncTransactionQueue syncQueue,
		ShellTaskOrganizer taskOrganizer, MainStage mainStage, SideStage sideStage,
		ShellTaskOrganizer taskOrganizer, MainStage mainStage, StageTaskListener sideStage,
		DisplayController displayController, DisplayImeController displayImeController,
		DisplayInsetsController displayInsetsController, SplitLayout splitLayout,
		Transitions transitions, TransactionPool transactionPool, ShellExecutor mainExecutor,
		@@ -507,7 +507,7 @@ public class StageCoordinator implements SplitLayout.SplitLayoutHandler,

		/**
		* {@link MainStage} will be deactivated in {@link #onStageHasChildrenChanged} if the
		* {@link SideStage} no longer has children.
		* other stages no longer have children.
		*/
		final boolean result = mSideStage.removeTask(taskId,
		isSplitActive() ? mMainStage.mRootTaskInfo.token : null,

libs/WindowManager/Shell/src/com/android/wm/shell/splitscreen/StageTaskListener.java

+24 −0

Original line number	Diff line number	Diff line
		@@ -475,6 +475,30 @@ public class StageTaskListener implements ShellTaskOrganizer.TaskListener {
		});
		}

		// --------
		// Previously only used in SideStage
		boolean removeAllTasks(WindowContainerTransaction wct, boolean toTop) {
		ProtoLog.d(WM_SHELL_SPLIT_SCREEN, "remove all side stage tasks: childCount=%d toTop=%b",
		mChildrenTaskInfo.size(), toTop);
		if (mChildrenTaskInfo.size() == 0) return false;
		wct.reparentTasks(
		mRootTaskInfo.token,
		null /* newParent */,
		null /* windowingModes */,
		null /* activityTypes */,
		toTop);
		return true;
		}

		boolean removeTask(int taskId, WindowContainerToken newParent, WindowContainerTransaction wct) {
		final ActivityManager.RunningTaskInfo task = mChildrenTaskInfo.get(taskId);
		ProtoLog.d(WM_SHELL_SPLIT_SCREEN, "remove side stage task: task=%d exists=%b", taskId,
		task != null);
		if (task == null) return false;
		wct.reparent(task.token, newParent, false /* onTop */);
		return true;
		}

		private void sendStatusChanged() {
		mCallbacks.onStatusChanged(mRootTaskInfo.isVisible, mChildrenTaskInfo.size() > 0);
		}