Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 36a861b2 authored by Alex Chau's avatar Alex Chau
Browse files

Remove extra padding between Notification header and inline_controls 

- Make header in notification_info / partial_conversation_info
  wrap_content, same way that notification_conversation_info does, add
  add a 11dp padding at top of the header

Test: Manual (See Bug)
Bug: 153886426
Change-Id: If57ce8d3c2badf8d7a80e7396f5bb8f1b3605ebc
parent b4ada778

packages/SystemUI/res/layout/notification_conversation_info.xml

+1 −1
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ 
        android:layout_height="wrap_content"

        android:gravity="center_vertical"

        android:clipChildren="false"

        android:paddingTop="11dp"

        android:paddingTop="@dimen/notification_guts_header_top_padding"

        android:clipToPadding="true">

        <ImageView

            android:id="@+id/conversation_icon"

packages/SystemUI/res/layout/notification_info.xml

+3 −2
Original line number Diff line number Diff line
@@ -30,10 +30,11 @@ 
    <LinearLayout

        android:id="@+id/header"

        android:layout_width="match_parent"

        android:layout_height="@dimen/notification_guts_conversation_header_height"

        android:layout_height="wrap_content"

        android:gravity="center_vertical"

        android:clipChildren="false"

        android:clipToPadding="false">

        android:paddingTop="@dimen/notification_guts_header_top_padding"

        android:clipToPadding="true">

        <ImageView

            android:id="@+id/pkg_icon"

            android:layout_width="@dimen/notification_guts_conversation_icon_size"

packages/SystemUI/res/layout/partial_conversation_info.xml

+3 −2
Original line number Diff line number Diff line
@@ -30,10 +30,11 @@ 
    <LinearLayout

        android:id="@+id/header"

        android:layout_width="match_parent"

        android:layout_height="@dimen/notification_guts_conversation_header_height"

        android:layout_height="wrap_content"

        android:gravity="center_vertical"

        android:clipChildren="false"

        android:clipToPadding="false">

        android:paddingTop="@dimen/notification_guts_header_top_padding"

        android:clipToPadding="true">

        <ImageView

            android:id="@+id/icon"

            android:layout_width="@dimen/notification_guts_conversation_icon_size"

packages/SystemUI/res/values/dimens.xml

+2 −0
Original line number Diff line number Diff line
@@ -226,6 +226,8 @@ 
    <dimen name="notification_guts_conversation_action_text_padding_start">32dp</dimen>

    <dimen name="conversation_onboarding_bullet_gap_width">6dp</dimen>



    <dimen name="notification_guts_header_top_padding">11dp</dimen>



    <!-- The height of the header in inline settings -->

    <dimen name="notification_guts_header_height">24dp</dimen>