Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 365ea4e1 authored by Brian Delwiche's avatar Brian Delwiche
Browse files

Improve audio sharing password handling 

This is a backport of ag/31824318.  ag/31424453 against the same bug is
superseded by these changes and need not be backported.

Test: atest
Bug: 389127608
Ignore-AOSP-First: security
Tag: #security
Merged-In: I10c21973340ff4bc8e4f1507b1136890aad43715
Merged-In: I2994fdbfd2aa71970e195bd2989f9abe3246c9cb
Change-Id: If2ad220dc2f4890ee67be62962a9b25d2f803e24
parent 6c3b4fde

packages/SettingsLib/src/com/android/settingslib/bluetooth/LocalBluetoothLeBroadcast.java

+15 −5
Original line number Diff line number Diff line
@@ -39,10 +39,10 @@ import androidx.annotation.RequiresApi; 
import com.android.settingslib.R;



import java.nio.charset.StandardCharsets;

import java.security.SecureRandom;

import java.util.ArrayList;

import java.util.Collections;

import java.util.List;

import java.util.UUID;

import java.util.concurrent.Executor;

import java.util.concurrent.Executors;

import java.util.concurrent.ThreadLocalRandom;
@@ -56,6 +56,10 @@ public class LocalBluetoothLeBroadcast implements LocalBluetoothProfile { 
    private static final String TAG = "LocalBluetoothLeBroadcast";

    private static final int UNKNOWN_VALUE_PLACEHOLDER = -1;

    private static final boolean DEBUG = BluetoothUtils.D;

    private static final String VALID_PASSWORD_CHARACTERS =

            "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789!@#$%^&*()-_=+[]{}|;:,"

                    + ".<>?/";

    private static final int PASSWORD_LENGTH = 16;



    static final String NAME = "LE_AUDIO_BROADCAST";

    // Order of this profile in device profiles list
@@ -502,9 +506,15 @@ public class LocalBluetoothLeBroadcast implements LocalBluetoothProfile { 
        mBroadcastId = UNKNOWN_VALUE_PLACEHOLDER;

    }



    private String generateRandomPassword() {

        String randomUUID = UUID.randomUUID().toString();

        //first 12 chars from xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx

        return randomUUID.substring(0, 8) + randomUUID.substring(9, 13);

    private static String generateRandomPassword() {

        SecureRandom random = new SecureRandom();

        StringBuilder stringBuilder = new StringBuilder(PASSWORD_LENGTH);



        for (int i = 0; i < PASSWORD_LENGTH; i++) {

            int randomIndex = random.nextInt(VALID_PASSWORD_CHARACTERS.length());

            stringBuilder.append(VALID_PASSWORD_CHARACTERS.charAt(randomIndex));

        }



        return stringBuilder.toString();

    }

}