Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 365501c6 authored by Bartosz Chominski's avatar Bartosz Chominski
Browse files

Clean-up of task move request bounds adjustment stubs in Core 

Following discussion in
https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/33630551/comment/cb2c799d_65ae570d/,
there does not seem to be any valid case in which bounds should be
adjusted by Core.

Bug: 400407139
Fix: 421882376
Flag: com.android.window.flags.enable_window_repositioning_api
Test: N/A
Change-Id: Ida2683ca9ad77d70cf22135fdc385b4f0adf1719
parent d37a9688

services/core/java/com/android/server/wm/AppTaskImpl.java

+0 −8
Original line number Diff line number Diff line
@@ -207,7 +207,6 @@ class AppTaskImpl extends IAppTask.Stub { 
                    displayId = task.getDisplayId();

                }



                adjustTaskMoveRequestBounds(displayId, bounds);

                final int result = validateTaskMoveRequest(displayId, bounds, task,

                        origCallingPid, origCallingUid);

                if (result != RESULT_APPROVED) {
@@ -323,13 +322,6 @@ class AppTaskImpl extends IAppTask.Stub { 
        return RESULT_APPROVED;

    }



    private void adjustTaskMoveRequestBounds(int displayId, Rect bounds) {

        // TODO(b/421882376): add a best-effort strategy that fixes |displayId| and |bounds| if

        // needed. Some possible fixes: moving the bounds inside the display, ensuring minimal and

        // maximal size requirements are met, more complex topology-based fixes including changing

        // the target display if the bounds are fully offscreen.

    }



    @Override

    public int startActivity(IBinder whoThread, String callingPackage, String callingFeatureId,

            Intent intent, String resolvedType, Bundle bOptions) {